Send/Sync cleanup #268
Merged
Send/Sync cleanup #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arc<Scheduler> to &'static Scheduler
controll collector context.
qinsoon
added
the
PR-testing
k-sareen
pushed a commit
to k-sareen/mmtk-core
that referenced
this pull request
Jun 10, 2021
* Remove unsafe impl Send/Sync for MMTK. Remove unsafe cast from Arc<Scheduler> to &'static Scheduler * Removed manual impl of Send/Sync for MutatorConfig, each plan, and controll collector context. * Remove unsafe impl of Sync/Send for a few work packets * Refactor for Scheduler.channel * Explain unsafe Sync for spaces. Remove some unsafe Sync/Send for SFT. * Only need Send for Work/GCWork/ProcessEdges (not Sync) * Remove unsafe impl for WorkBucket * Remove unnecessary Send/Sync super trait for some traits. * Some comments about unsafe Sync/Send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up our code around the
SendandSynctraits. It is one step for #97.Send/Syncfor certain types. For example:PlanisSyncas it is shared across thread, but it is notSendas we do not send its ownership to another thread.WorkisSendas it will be sent to worker threads, but it is notSyncas we should not share it across threads.unsafe impl Send/Syncto the exact type where it is needed.GenCopyisSync, but it usesCommonPlan, andCommonPlanusesUnsafeCellwhich prevents Rust derivingSyncforCommonPlansafely. We shouldunsafe impl SyncforCommonPlanrather thanGenCopy.unsafe impl Send/Sync.This PR should only be merged after we release 0.3.