Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able change version of Alloy that is used with Appc CLI #4

Open
brentonhouse opened this issue Mar 3, 2016 · 6 comments

Comments

@brentonhouse
Copy link
Contributor

As a developer,
I want to be able to be able to use a different version (or custom build) of Alloy when using the Appcelerator CLI,
So that I can be able to patch urgent issues and critical defects while waiting for a new version of Alloy

With the old build system (Titanium or Ti), I could simply run npm install -g alloy@versionx to get a different or custom build of Alloy used with a build. Now with the new build system (Appcelerator or Appc), A specific version of Alloy is bundled with the Appcelerator Platform and there is not a simple way to change it on all our developer and build machines.
If there is known way of doing this already, please let us know!

We have an Enterprise license and this is critical for us right now as we have a memory leak that we need to patch in Alloy and get it into production quickly.

Associated JIRA Ticket: https://jira.appcelerator.org/browse/AC-661

Workaround

@FokkeZB proposed adding a global hook that contains this:

delete process.env.ALLOY_PATH;

https://jira.appcelerator.org/browse/TIMOB-20512

@FokkeZB
Copy link
Contributor

FokkeZB commented Mar 29, 2016

@brentonhouse if you'd like to contain this within the adamantium project you could install a global CLI hook as part of installing the global Alloy CLI. See how TiShadow does the same:

https://github.com/dbankier/TiShadow/blob/master/package.json#L47

@brentonhouse
Copy link
Contributor Author

@FokkeZB Maybe even create a parameter that could enable/disable it so that you could compile using "real" alloy if you wanted to.

@FokkeZB
Copy link
Contributor

FokkeZB commented Mar 29, 2016

That's probably not going to happen anymore as Alloy is being refactored.

@brentonhouse
Copy link
Contributor Author

Couldn't I look for a parameter in cli:go hook and then conditionally execute delete process.env.ALLOY_PATH; depending on what the parameter value was? Are these being refactored as well?

@FokkeZB
Copy link
Contributor

FokkeZB commented Mar 29, 2016

All of CLI tooling is getting refactored, but of course until then you can introduce a option (like TiShadow does --express) to trigger the global CLI to be used.

@brentonhouse
Copy link
Contributor Author

ah, gotcha. I will try to keep up w/ the changes to adapt.

@brentonhouse brentonhouse removed their assignment Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants