Support concrete playback for arrays of length 65 or greater #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynzech
changed the title
carolynzech
force-pushed
the
issue-3787
branch
3 times, most recently
from
f1d8119 to
37aadf1
Compare
carolynzech
force-pushed
the
issue-3787
branch
from
37aadf1 to
9c876f2
Compare
rajath-mk
reviewed
Feb 13, 2025
rajath-mk
approved these changes
Feb 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Resolves #3891 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Michael Tautschnig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When CBMC generates a JSON trace for a nondeterministic array, it will output a key-value pair
elements: [array], wherearraycontains concrete values for each element in the array. If the array is length 64 or shorter, it will also output the elements of the array as separate values in the trace (so each element is in the trace twice). Prior to this PR, concrete playback relied on the latter output format to find elements of an array. However, when the array was length 65 or greater, those elements wouldn't be values in their own right, so we wouldn't find any values for the array and just output an empty array.Solution
This PR changes our representation of concrete values to handle arrays explicitly; i.e., to look for the
elementsarray and populate the concrete values of the array from that instead.Callouts
For those wondering why the
playback_already_existedtest changed, it's because we're hashingConcreteIteminstead ofConcreteValue, so the hash changes.Resolves #3787
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.