Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assertion the lhs.typ() and rhs.typ() are equal for assignments #418

Closed

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Aug 11, 2021

Description of changes:

RMC had a workaround because some tests failed when we asserted that assignments must have matching types. The underlying bugs appear to have been fixed, so enable the assertion

Resolved issues:

Resolves #95

Call-outs:

Testing:

  • How is this change tested? Existing regression suite

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@danielsn danielsn closed this Aug 12, 2021
@danielsn danielsn deleted the assert-on-assign branch September 24, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statement assignment assert failing
1 participant