Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numpy): aliases of builtin types is deprecated as of numpy 1.20 #1052

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Feb 8, 2021

These changes shouldn't change anything, since types like np.int are alias to builtin int types. These alias are deprecated as of numpy 1.20.

A few considerations to note:

  • There might be some cases where (e.g.) np.int32 should have been specified. This should only be important while reading/writing unformatted data.
  • On Windows, the builtin int for NumPy means np.int32, while on other systems it is np.int64.

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #1052 (b400718) into develop (3ccdd57) will decrease coverage by 16.390%.
The diff coverage is 0.000%.

@@              Coverage Diff              @@
##           develop    #1052        +/-   ##
=============================================
- Coverage   16.390%   0.000%   -16.391%     
=============================================
  Files          225      225                
  Lines        50699    50699                
=============================================
- Hits          8310        0      -8310     
- Misses       42389    50699      +8310     
Impacted Files Coverage Δ
flopy/discretization/grid.py 0.000% <ø> (-46.875%) ⬇️
flopy/discretization/unstructuredgrid.py 0.000% <0.000%> (-16.863%) ⬇️
flopy/export/shapefile_utils.py 0.000% <0.000%> (-10.968%) ⬇️
flopy/export/utils.py 0.000% <0.000%> (-3.671%) ⬇️
flopy/export/vtk.py 0.000% <0.000%> (-7.340%) ⬇️
flopy/mf6/coordinates/simulationtime.py 0.000% <ø> (-38.889%) ⬇️
flopy/mf6/data/mffileaccess.py 0.000% <0.000%> (-6.043%) ⬇️
flopy/mf6/data/mfstructure.py 0.000% <0.000%> (-13.645%) ⬇️
flopy/mf6/mfmodel.py 0.000% <0.000%> (-13.410%) ⬇️
flopy/mf6/utils/mfobservation.py 0.000% <0.000%> (-12.555%) ⬇️
... and 266 more

@langevin-usgs
Copy link
Contributor

Looks like our testing is being bitten by a weird shapely issue (as also mentioned here: #1033). @mwtoews any idea what's going on here? This seems like it's in your wheelhouse.

By the way, thanks for all this cleanup on our np.aliases. Very helpful and good to know.

@langevin-usgs
Copy link
Contributor

This PR would have passed, except for the geos version issue, which was fixed by a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants