Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pikaday uses date format that Filtrex doesn't recognize breaking filter #153

Closed
sezaru opened this issue Apr 24, 2020 · 2 comments
Closed

Comments

@sezaru
Copy link
Contributor

sezaru commented Apr 24, 2020

Torch javascript creates Pikaday objects without forcing a format definition, from torch.js:
new Pikaday({field: field, theme: 'torch-datepicker'})

This means that some client configurations will have other date formats as default and break the filter code, for example, in my machine Pikaday will return this format: Thu Apr 09 2020.

The solution seems to be by adding the format field they support during object creation.

@cpjolicoeur
Copy link
Member

Sounds good. Do you want to take a crack at this @sezaru and submit a Pull Request?

@cpjolicoeur
Copy link
Member

closed by #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants