Fixes pikaday date formating to YYYY-MM-DD #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we possibly avoid having to add the extra dependency on |
|
I think we can, but I tried it and I think I got their 870 issue, but I'm not 100% sure.. I think we can try using some built-in date format for javascript in |
|
Just updated it, now without moment.js, what do you think? |
|
@sezaru Thanks, I like that better. Can you squash these commits down into a single commit since the 2nd commit changes most of the first, and then we'll get this merged? |
|
Done |
|
@sezaru Version 3.2.1 has been released with these changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces format of pikaday to always be YYYY-MM-DD.
There is a way to do the same without moment.js, but it seems broken now, so it would need master version of pikaday. More info in Pikaday/Pikaday#870
PS. I didn't run webpack to generate the new packed js files.