Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated usage of core methods. #211

Closed
cpjolicoeur opened this issue Mar 19, 2021 · 3 comments · Fixed by #268
Closed

Removed deprecated usage of core methods. #211

cpjolicoeur opened this issue Mar 19, 2021 · 3 comments · Fixed by #268
Labels
good first issue help wanted maintenance

Comments

@cpjolicoeur
Copy link
Member

Torch.FilterView.filter_text_input/3 is deprecated. Use filter_string_input/3 instead in generated template files.
@eethann
Copy link

eethann commented Sep 22, 2021

Hi, I'm interested in helping out with this. Will clone and take a look.

@cpjolicoeur
Copy link
Member Author

@eethann Thanks. There really is only a single place in the generator templates left that still uses the old method and needs updating. But take a look and if you have any questions just let me know.

@cpjolicoeur
Copy link
Member Author

@eethann any follow-up on this or should I go ahead and take care of this myself?

cpjolicoeur added a commit that referenced this issue Oct 25, 2021
@cpjolicoeur
Remove usage of deprecated method
15967e3 
[close #211]
@cpjolicoeur cpjolicoeur mentioned this issue Oct 25, 2021
Merged
cpjolicoeur added a commit that referenced this issue Oct 25, 2021
@cpjolicoeur
Remove usage of deprecated method
63445ee 
[close #211]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usage of deprecated method mojotech/torch
2 participants
@cpjolicoeur @eethann