Restrict pagination links to groups of 10 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinwilson
commented
Sep 19, 2016
| end | ||
| defp end_page(current_page, _total, distance) do | ||
| current_page + distance - 1 | ||
| end |
There was a problem hiding this comment.
This logic was mostly cribbed from scrivener_html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19 by adding Google-style pagination links: the number of pagination links is restricted by a
distancesetting, with the current page placed (roughly) in the center.The
distancesetting can be configured in the controller, but the pagination template falls back to a default value of 5 if the value is not set. This is to preserve backward compatibility with pages generated by older versions of torch.