Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert NodeList objects into an Array before using forEach #29

Merged
merged 2 commits into from
Sep 27, 2016
Merged

Convert NodeList objects into an Array before using forEach #29

merged 2 commits into from
Sep 27, 2016

Conversation

silasjmatson
Copy link
Contributor

forEach does not exist on NodeList in Safari. This PR will fix by converting the NodeList objects to an Array

Fixes #28

danielberkompas
danielberkompas approved these changes Sep 26, 2016
View reviewed changes
Copy link
Contributor

@danielberkompas danielberkompas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as you've manually tested this in Safari.

@silasjmatson
Copy link
Contributor Author

@danielberkompas Testing now. Shoulda done that first, oops. :P

@silasjmatson
Copy link
Contributor Author

@danielberkompas Tested and verified working in Safari & Chrome.

@darinwilson darinwilson merged commit 9d128ec into master Sep 27, 2016
@darinwilson darinwilson deleted the fix/javascript-safari-error branch September 27, 2016 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielberkompas danielberkompas danielberkompas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Javascript Errors in Safari
3 participants
@silasjmatson @danielberkompas @darinwilson