Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] Fix query string #39

Merged
merged 3 commits into from
Mar 11, 2017
Merged

Conversation

danielberkompas
Copy link
Contributor

See commits for more details. Closes #22.

@darinwilson
Copy link
Contributor

The changes look good, but CI doesn't like the TODOs in the comments.

These changes allow the query string to be preserved with pagination, so
you can start a search and then page through the results.
The templates in the `apps/example` app needed to be regenerated using
the `mix regenerate` command.
@danielberkompas danielberkompas force-pushed the bugfix/22/page-query-string branch from 8883b50 to 407d23a Compare March 11, 2017 22:50
@danielberkompas danielberkompas merged commit 8af9e4b into master Mar 11, 2017
@danielberkompas danielberkompas deleted the bugfix/22/page-query-string branch March 11, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants