ENH: Multiframe support #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to disable rescaling with monkey patching...
moloney
force-pushed
the
enh-multiframe
branch
from
ea1f50f to
2812ffe
Compare
As pointed out in [Debian bugs #1063943] and [then #1071794], test/test_cli.py fails with pytest 8 and beyon with the following symptoms: __________________________ TestDcmstackCli.test_basic __________________________ self = <test.test_cli.TestDcmstackCli object at 0x7f2d3a00eb40> def test_basic(self): > nii_paths = make_niftis(self.out_dir) E AttributeError: 'TestDcmstackCli' object has no attribute 'out_dir' test/test_cli.py:55: AttributeError __________________________ TestDcmstackCli.test_embed __________________________ self = <test.test_cli.TestDcmstackCli object at 0x7f2d3c976180> def test_embed(self): > nii_paths = make_niftis(self.out_dir, ['--embed']) E AttributeError: 'TestDcmstackCli' object has no attribute 'out_dir' test/test_cli.py:59: AttributeError ___________________________ TestNitoolCli.test_basic ___________________________ self = <test.test_cli.TestNitoolCli object at 0x7f2d39f5b1d0> def test_basic(self): > nii_path = make_niftis(self.out_dir, ['--embed'])[0] E AttributeError: 'TestNitoolCli' object has no attribute 'out_dir' test/test_cli.py:65: AttributeError This is because pytest 8 deprecated the use of plain _setup_ and _teardown_, which were compatibility layers to ease the porting effort from Nose. This change ensures methods inheriting from CliTest get set up and teared down properly. [Debian bugs #1063943]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063943 [then #1071794]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071794 Signed-off-by: Étienne Mollier <[email protected]>
t/test_cli.py: port setup/teardown to pytest 8.
prefer newer unittest.mock from standard library
Have to disable rescaling with monkey patching...
moloney
changed the title
This was referenced Nov 20, 2024
This was referenced Nov 20, 2024
Performance should be better in general, but partiularly when not parsing all elements. Handling of private elements should be better and the names now inlcude the "Private Creator".
Provide four pre-configured levels of extraction. Update CLI to reflect these changes. Fix bug with handling of pixel scaling.
If we find MosaicRefAcqTimes use them when computing normalized element 'SND.AcquisitionTimeStamp'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.