Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46918: Rename Connection::getMongoDB to getDatabase #3292

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Feb 27, 2025

Jira issue

Docs PR

Didn't see any references to Connection::getMongoClient in the docs, so only renamed the usages of getMongoDB.

Staging

@mcmorisi mcmorisi requested a review from a team as a code owner February 27, 2025 16:47
@mcmorisi mcmorisi requested a review from rustagir February 27, 2025 16:47
@github-actions github-actions bot added the docs label Feb 27, 2025
@mcmorisi mcmorisi changed the title Rename Connection::getMongoDB to getDatabase DOCSP-46918: Rename Connection::getMongoDB to getDatabase Feb 27, 2025
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcmorisi mcmorisi requested a review from GromNaN February 27, 2025 17:01
@@ -225,7 +225,7 @@ the collections in the database:

.. code-block:: php

$collections = DB::connection('mongodb')->getMongoDB()->listCollections();
$collections = DB::connection('mongodb')->getDatabase()->listCollections();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he paragraph before this example can be fixed:

The following example accesses the database of the connection,

@mcmorisi mcmorisi enabled auto-merge (squash) February 27, 2025 19:41
@mcmorisi mcmorisi disabled auto-merge February 27, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants