Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2847 Update CSOT encryption test for listCollections #1564

Merged
merged 2 commits into from
Jun 10, 2024
Merged

DRIVERS-2847 Update CSOT encryption test for listCollections #1564

merged 2 commits into from
Jun 10, 2024

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Apr 11, 2024 •
edited
Loading

DRIVERS-2847

  • Fix client-side encryption test in timeoutMS.yml by correcting the number of expected listCollections operations to one, based on libmongocrypt's caching behavior.
  • Update description to reflect that the internal MongoClient, not configured for auto encryption, does not generate extra listCollections events.

Please complete the following before merging:

  • Update changelog. (no changelog)
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

Tested in Java driver mongodb/mongo-java-driver#1363.

@vbabanin vbabanin requested a review from ShaneHarvey April 11, 2024 14:41
@vbabanin vbabanin marked this pull request as ready for review April 11, 2024 14:42
@vbabanin vbabanin requested a review from a team as a code owner April 11, 2024 14:42
@vbabanin vbabanin requested review from katcharov and removed request for a team April 11, 2024 14:42
@qingyang-hu qingyang-hu self-requested a review April 23, 2024 17:34
@ShaneHarvey ShaneHarvey changed the title Update CSOT test definition. DRIVERS-2847 Update CSOT encryption test for listCollections Apr 23, 2024
@jyemin
Copy link
Contributor

jyemin commented Jun 4, 2024

@ShaneHarvey do you plan to review this?

@qingyang-hu qingyang-hu mentioned this pull request Jun 4, 2024
Draft
ShaneHarvey
ShaneHarvey approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had deferred this review to Qingyang but forgot to take myself off the PR reviewer list.

@vbabanin vbabanin merged commit 5984422 into mongodb:master Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov katcharov approved these changes

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@qingyang-hu qingyang-hu qingyang-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbabanin @jyemin @katcharov @ShaneHarvey @qingyang-hu