Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] FileTest.LastWriteTimeSubMsCopy fails #10447

Closed
lewurm opened this issue Sep 3, 2018 · 4 comments
Closed

[iOS] FileTest.LastWriteTimeSubMsCopy fails #10447

lewurm opened this issue Sep 3, 2018 · 4 comments
Labels
target-xamarin-ios
Milestone
2018-06 (5.16.xx)

Comments

@lewurm
Copy link
Contributor

lewurm commented Sep 3, 2018 •
edited
Loading

see dotnet/macios#4277 (comment)

Steps to Reproduce

  1. build mono-2018-06 branch from xamarin/xamarin-macios
  2. run FileTest.LastWriteTimeSubMsCopy 32-bit or 64-bit mode on an iOS 10.3.3 device

since it worked on 2018-04 (?) the possible candidates for this regression are:

potential missing piece:
@lewurm lewurm added this to the 2018-06 (5.16.xx) milestone Sep 3, 2018
@lewurm
Copy link
Contributor Author

lewurm commented Sep 3, 2018

as pointed out by @rolfbjarne on Slack:

it started failing after this bump: dotnet/macios@b3245a6
which is a8b65e1...f9c42ea
which has this copyfile commit: 341142d (= #10010)

@lewurm
Copy link
Contributor Author

lewurm commented Sep 3, 2018 •
edited
Loading

FWIW, I can't reproduce it on a 32-bit device (iPhone 5c) with iOS 10.3.3 and neither on a 64-bit device (iPhone 7) with iOS 11.4.1.

I was able to reproduce it on the 32-bit simulator with iOS 10.3.1 though.

@lewurm lewurm mentioned this issue Sep 3, 2018
Merged
monojenkins added a commit that referenced this issue Sep 5, 2018
@monojenkins
Merge pull request #10455 from lewurm/2018-06-osx-clonefile
9439ee6 
[2018-06] Use clonefile instead of copyfile on macOS

* Revert of #10010 
* Backport of #10020

Fixes #10447


/cc @filipnavara
@lewurm
Copy link
Contributor Author

lewurm commented Sep 5, 2018

fixed by #10455

@lewurm lewurm closed this as completed Sep 5, 2018
@filipnavara
Copy link
Contributor

JFYI the test case is not very well written. It would be nice to ensure that the original file before the copy has time with nano-seconds by explicitly setting it and then compare the exact time stamp after the copy.

@directhex directhex mentioned this issue Oct 1, 2018
Merged
jonpryor pushed a commit to dotnet/android that referenced this issue Oct 9, 2018
@directhex @jonpryor
Bump to mono/mono:2018-06@ab3c897d (#1836)
606675b 
Bumps to mono/llvm:release_60@117a508c
Bumps to xamarin/xamarin-android-api-compatibility:master@7ccb4802

	$ git diff --shortstat e1af6ea..ab3c897d       # mono
        1443 files changed, 66049 insertions(+), 45745 deletions(-)
	$ git diff --shortstat bdb3a116..117a508c      # llvm
	 26794 files changed, 4110589 insertions(+), 754376 deletions(-)
	$ git diff --shortstat c550d1bd..7ccb4802      # xamarin-android-api-compatibility
	 2 files changed, 16260 insertions(+), 12347 deletions(-)

Incomplete summary of easily `grep`able fixes:

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=11199
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=19436
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=23668
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=26983
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=33728
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=46917
fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60065
Fixes: mono/mono#6173
Fixes: mono/mono#6466
Fixes: mono/mono#6647
Fixes: mono/mono#6834
Fixes: mono/mono#7058
Fixes: mono/mono#7137
Fixes: mono/mono#7260
Fixes: mono/mono#7305
Fixes: mono/mono#7402
Fixes: mono/mono#7525
Fixes: mono/mono#7610
Fixes: mono/mono#7649
Fixes: mono/mono#7655
Fixes: mono/mono#7683
Fixes: mono/mono#7685
Fixes: mono/mono#7716
Fixes: mono/mono#7731
Fixes: mono/mono#7785
Fixes: mono/mono#7828
Fixes: mono/mono#7944
Fixes: mono/mono#7947
Fixes: mono/mono#8036
Fixes: mono/mono#8074
Fixes: mono/mono#8089
Fixes: mono/mono#8112
Fixes: mono/mono#8122
Fixes: mono/mono#8143
Fixes: mono/mono#8149
Fixes: mono/mono#8152
Fixes: mono/mono#8175
Fixes: mono/mono#8177
Fixes: mono/mono#8250
Fixes: mono/mono#8267
Fixes: mono/mono#8273
Fixes: mono/mono#8282
Fixes: mono/mono#8310
Fixes: mono/mono#8311
Fixes: mono/mono#8329
Fixes: mono/mono#8340
Fixes: mono/mono#8372
Fixes: mono/mono#8407
Fixes: mono/mono#8409
Fixes: mono/mono#8422
Fixes: mono/mono#8430
Fixes: mono/mono#8439
fixes: mono/mono#8447
Fixes: mono/mono#8469
Fixes: mono/mono#8504
Fixes: mono/mono#8575
Fixes: mono/mono#8597
Fixes: mono/mono#8623
Fixes: mono/mono#8627
Fixes: mono/mono#8698
Fixes: mono/mono#8701
Fixes: mono/mono#8712
Fixes: mono/mono#8721
Fixes: mono/mono#8726
Fixes: mono/mono#8759
Fixes: mono/mono#8787
Fixes: mono/mono#8820
Fixes: mono/mono#8848
Fixes: mono/mono#8866
Fixes: mono/mono#8897
Fixes: mono/mono#8915
Fixes: mono/mono#8970
Fixes: mono/mono#8979
Fixes: mono/mono#9023
Fixes: mono/mono#9031
Fixes: mono/mono#9033
Fixes: mono/mono#9179
Fixes: mono/mono#9234
Fixes: mono/mono#9262
Fixes: mono/mono#9277
Fixes: mono/mono#9318
Fixes: mono/mono#9542
Fixes: mono/mono#9753
Fixes: mono/mono#9839
Fixes: mono/mono#9869
Fixes: mono/mono#9870
Fixes: mono/mono#9943
Fixes: mono/mono#9996
Fixes: mono/mono#10000
Fixes: mono/mono#10303
Fixes: mono/mono#10447
Fixes: mono/mono#10483
Fixes: mono/mono#10488
Fixes: xamarin/maccore#628
Fixes: xamarin/maccore#673
Fixes: #1561 (comment)
Fixes: #1845
Fixes: dotnet/macios#4347
Fixes: dotnet/macios#4617
Fixes: dotnet/macios#4618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
target-xamarin-ios
Projects
None yet
Milestone
2018-06 (5.16.xx)
Development

No branches or pull requests
2 participants
@lewurm @filipnavara