Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semrush Audit February #1102

Merged

Conversation

0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Feb 14, 2025

Description

This audit was smaller than last month's; I fixed a broken image link and added the corresponding image to the correct folder.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If images have been added, I have run the compress-images.py script to compress the images.

@eshaben eshaben added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task labels Feb 18, 2025
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we actually don't need one of the images

@0xlukem 0xlukem requested a review from eshaben February 18, 2025 23:57
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing analytics? I thought that was the main issue.

There's also a ### Create a Fork section on this page. If forks have been renamed or updated to virtual testnets, we should follow suit in that section too. Looks like that whole section might need to be updated

@0xlukem 0xlukem requested a review from eshaben February 20, 2025 01:28
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the images!

I think this could have benefited from looking at it with fresh eyes. Remember to review it from GitHub and also review it on the page. It's always good to review your own PRs before requesting someone else to review.

Also... grammarly!

@0xlukem 0xlukem requested a review from eshaben February 24, 2025 22:22
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you zooming in on these screenshots? The text is kinda small on some of them. I think in the style guide it says 150% zoom. Sometimes we bump that down depending on what the screen looks like. But as a general rule of thumb, the text in the image should be the same size as the text we use on our docs

Please delete all of the .DS_Store files that were added

@0xlukem 0xlukem requested a review from eshaben February 26, 2025 00:16
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet. Images all look good. I think the one thing the Moonbeam docs suffer from is wordiness, so I provided some suggestions to make it more concise. I think one of the things when you go into pages like this, it can be good to have the "boy scout" mentality of leave it better than you found it haha

@0xlukem 0xlukem requested a review from eshaben February 27, 2025 19:58
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Feb 27, 2025
@eshaben eshaben merged commit e796a8a into moonbeam-foundation:master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants