-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semrush Audit February #1102
Semrush Audit February #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that we actually don't need one of the images
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about removing analytics? I thought that was the main issue.
There's also a ### Create a Fork section on this page. If forks have been renamed or updated to virtual testnets, we should follow suit in that section too. Looks like that whole section might need to be updated
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the images!
I think this could have benefited from looking at it with fresh eyes. Remember to review it from GitHub and also review it on the page. It's always good to review your own PRs before requesting someone else to review.
Also... grammarly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you zooming in on these screenshots? The text is kinda small on some of them. I think in the style guide it says 150% zoom. Sometimes we bump that down depending on what the screen looks like. But as a general rule of thumb, the text in the image should be the same size as the text we use on our docs
Please delete all of the .DS_Store
files that were added
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeet. Images all look good. I think the one thing the Moonbeam docs suffer from is wordiness, so I provided some suggestions to make it more concise. I think one of the things when you go into pages like this, it can be good to have the "boy scout" mentality of leave it better than you found it haha
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This audit was smaller than last month's; I fixed a broken image link and added the corresponding image to the correct folder.
Checklist
compress-images.py
script to compress the images.