Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ofac: SDN comments contains improper quotes #248

Closed
adamdecaf opened this issue Mar 3, 2020 · 0 comments · Fixed by #250
Closed

ofac: SDN comments contains improper quotes #248

adamdecaf opened this issue Mar 3, 2020 · 0 comments · Fixed by #250
Assignees
@adamdecaf
Labels
bug Something isn't working

Comments

@adamdecaf
Copy link
Member

adamdecaf commented Mar 3, 2020 •
edited
Loading

The sdn_comments.csv file has improperly escaped quotes. Here's the problem record:

28264,"hone Number 8613314257947; alt. Phone Number 8618004121000; Identification Number 210302198701102136 (China); a.k.a. "blackjack1987"; a.k.a. "khaleesi"; Linked To: LAZARUS GROUP."

The quotes around"blackjack1987" and "khaleesi" should be escaped ( " ) .

I've emailed OFAC and am awaiting their response, for now we can probably fix this by removing inner quotes.

Screen Shot 2020-03-03 at 10 32 03 AM
@adamdecaf adamdecaf added the bug Something isn't working label Mar 3, 2020
@adamdecaf adamdecaf self-assigned this Mar 3, 2020
@adamdecaf adamdecaf mentioned this issue Mar 3, 2020
Open
adamdecaf added a commit to adamdecaf/watchman that referenced this issue Mar 3, 2020
@adamdecaf
ofac: allow unescaped inner quotes in SDN comments records
7ca07ce 
Fixes: moov-io#248
@adamdecaf adamdecaf mentioned this issue Mar 3, 2020
Merged
adamdecaf added a commit to adamdecaf/watchman that referenced this issue Mar 3, 2020
@adamdecaf
ofac: add filename and more logging context for debugging refresh errors
a1e0f91 
Issue: moov-io#248
adamdecaf added a commit that referenced this issue Mar 3, 2020
@adamdecaf
ofac: allow unescaped inner quotes in SDN comments records
ab8b074 
Fixes: #248
adamdecaf added a commit that referenced this issue Mar 3, 2020
@adamdecaf
ofac: add filename and more logging context for debugging refresh errors
a3afa65 
Issue: #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamdecaf adamdecaf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ofac: allow unescaped inner quotes in SDN comments records adamdecaf/watchman
1 participant
@adamdecaf