Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in precommit yml #439

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

daico007
Copy link
Member

PR Summary:

I made a typo when trying to add an exclusion for precommit yml, which lead to fail precommit test. This PR fix that typo.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@@ -14,7 +14,7 @@ repos:
- id: check-yaml
- id: end-of-file-fixer
- id: trailing-whitespace
args: 'setup.cfg'
exclude: 'setup.cfg'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think you need quotes around it.

Copy link
Contributor

@justinGilmer justinGilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit seems to pass. Assuming everything passes, lgtm.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #439 (f2b6dc2) into master (af8c0b5) will not change coverage.
The diff coverage is n/a.

❗ Current head f2b6dc2 differs from pull request most recent head 7b8f92b. Consider uploading reports for the commit 7b8f92b to get more accurate results

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files          17       17           
  Lines        1839     1839           
=======================================
  Hits         1358     1358           
  Misses        481      481           

@justinGilmer justinGilmer merged commit c8e789b into mosdef-hub:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants