Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smarts string for opls_154 #450

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Aug 7, 2021

PR Summary:

Update definition of opls_154 in oplsaa.xml, raised by #438. Tests were updated accordingly.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #450 (c530cf0) into master (78dbdaf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files          17       17           
  Lines        1842     1842           
=======================================
  Hits         1361     1361           
  Misses        481      481           

@justinGilmer justinGilmer merged commit 591aa97 into mosdef-hub:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The definition of opls_154 (oxygen in an alcohol) is not specific enough and will also match oxygen in water
2 participants