WIP: start l10n tooling #486

groovecoder · 2018-09-29T19:10:36Z

No description provided.

pdehaan · 2018-09-29T19:34:26Z

.env-dist

@@ -4,6 +4,9 @@ SERVER_URL=http://localhost:6060
 PORT=6060
 COOKIE_SECRET=3895d33b5f9730f5eb2a2067fe0a690e298f55f5e382c032fd3656863412

+# available languages for l20n
+AVAILABLE_LANGUAGES="de,en,es,fr,it,ja,pt,ru,zh"


Does this account for en-US, en-CA, en-UK, etc?

We should thoroughly test, but the accept-language module says that get will "Get the most likely language given an Accept-Language string".

pdehaan · 2018-09-29T19:35:47Z

.eslintignore

@@ -3,3 +3,4 @@ coverage
 loadtests
 public/dist
 public/js/polyfills
+public/js/l20n.js


Oy vey! Any chance we can import via npm versus copy-pasta this file below?

groovecoder · 2018-10-01T14:59:13Z

middleware.js

+
+function pickLanguage (req, res, next) {
+  acceptLanguage.languages(AppConstants.AVAILABLE_LANGUAGES.split(","));
+  req.app.locals.locale = acceptLanguage.get(req.headers["accept-language"]);


Code looks like it will default to whatever is the first language tag specified in acceptLanguage.languages. So in our case - yes.

pdehaan · 2018-09-30T07:31:14Z

public/locales/en/app.ftl

+
+terms = Terms&nbsp;and&nbsp;Privacy
+
+copyright = Portions of this content are © 1998-2018 by individual mozilla.org contributors. Content available under a Creative Commons license


Actual markup below is:

 Portions of this content are © 1998-2018 by individual mozilla.org contributors. Content available under a <a {{> analytics/link_event eventLabel="Creative Commons"}} href="https://www.mozilla.org/foundation/licensing/website-content/" target="_blank" rel="noopener">Creative Commons license</a>. 

Not sure if the .ftl files should use © entity or if we need anything special for link preserving.

pdehaan · 2018-09-30T07:33:00Z

public/locales/de/app.ftl

+
+terms = Allgemeine&nbsp;Geschäftsbedingungen&nbsp;und&nbsp;Datenschutzerklärung
+
+copyright = Teile dieses Inhalts sind © 1998-2018 von einzelnen mozilla.org-Mitwirkenden. Inhalt verfügbar unter einer Creative Commons-Lizenz


/cc @flodolo @stasm

Do either of you have any guidance or suggestions on bundling the .ftl files directly in the source repo, versus doing something like a separate "blurts-server-l10n" repo for translations?

Reasons to use a different repository:

History: Pontoon will write in the repository every 20 minutes, once for each locale (if there are changes). History is going to become messy very quickly.

Decouplement: You can develop on master and decide when strings are ready for translation.

Cons:

You need scripts to import strings back.

You need to expose strings in the l10n repository via PR.

Alternatively, we can also write in a branch instead of master, but then you need to deal with merges back and forth.

Side note: we'll need a dev server updated frequently for l10n testing. For that it might be easier to have the strings in the main repository.

From the point of view of configuration, if you want Pontoon to write here we just need to add its bot.

@flodolo can you point us to examples of each kind of setup? I.e., same-repo vs. separate-repo?

Screenshots and Test Pilot have strings in the main repo
https://github.com/mozilla-services/screenshots/
https://github.com/mozilla/testpilot/

For Test Pilot we use a l10n branch.

Other products use a repo for strings, but I don't have website examples at hands
strings: https://github.com/mozilla-l10n/firefoxios-l10n
code: https://github.com/mozilla-mobile/firefox-ios

The one separate-repo I can remember off the top of my head is FxA's content server:

https://github.com/mozilla/fxa-content-server
vs
https://github.com/mozilla/fxa-content-server-l10n

I think the trick was putting a package.json in the *-l10n repo so you can include it as a dependency in your main repo's package.json. But of course, as I went to prove that, I notice that FxA team is using some Bash script[1] to download locales, so we may want to sync up with them to see why they switched to doing it that way (or maybe I'm misremembering how it was done originally).

[1] https://github.com/mozilla/fxa-content-server/blob/master/scripts/download_l10n.sh

stasm · 2018-10-01T15:29:55Z

Thanks for the CC and for kicking this off.

l20n.js hasn't been actively developed in more than a year. We shifted focus completely to Fluent. I should really get to deprecating it officially (l20n/spec#17).

Instead, we have developed fluent (for parsing FTL files and formatting translations) and fluent-dom (for localizing the DOM), although they might require some additional work to set up. fluent-dom doesn't initialize the localization of the document automatically during the load of the page. Some glue code is needed to parse the links to FTL files form <head> and start the localization of the document.

There's an experimental packaged called fluent-web which provides this glue code together with the dependencies. We haven't had a strong driver to work on it recently. @zbraniecki will know the latest status of it.

For language negotiation there's also fluent-langneg which is well-tested and used by a number of other Mozilla web projects. It might make sense to use it here, too, although other packages available on npm should be OK as well.

pdehaan · 2018-10-01T16:57:28Z

Another good reference for fluent lib usage is the https://github.com/mozilla/send repo.

groovecoder · 2018-10-02T15:39:13Z

I looked thru send, screenshots, testpilot, and fluent-web and I prefer fluent-web by a large margin. I tried to simply replace l20n.js with fluent-web.js but it looks like fluent-web has some making & building steps that I can't figure out.

How long would it take to get fluent-web up to a usable state like l20n.js? Can it be done by the end of this week?

If not, I'll start digging into using fluent-dom directly.

zbraniecki · 2018-10-02T15:43:50Z

but it looks like fluent-web has some making & building steps that I can't figure out.

hg clone https://github.com/projectfluent/fluent-web
cd fluent-web
npm i
make build
open ./examples/simple.html

does that work?

groovecoder · 2018-10-02T19:15:09Z

I get SyntaxError: import declarations may only appear at top level of a module fluent-web.js:2

groovecoder · 2018-10-02T19:15:30Z

I'm happy to move this over to a fluent-web issue.

groovecoder · 2018-10-02T19:21:19Z

Opened projectfluent/fluent-web#2

groovecoder · 2018-10-03T21:36:34Z

Still waiting to see if we can use fluent-web for the front-end l10n, but I made a significant change to this PR for back-end l10n ...

On server start-up:
- scan public/locales directory for available languages
- instantiate a FluentBundle for each language
- keep both in app.locals
- app.use(pickLanguage) middleware
During request:
- pickLanguage checks Accept-Language and sets appropriate req.locale and req.fluentBundle
In back-end code, e.g., controllers/home.js, use req.fluentBundle.format(req.fluentBundle.getMessage("notFound") where it used to have the hard-coded English message.
- (could probably condense this with a locale.bundleMessage() helper function

This seems to work fine!

And it feels simpler than some of the other approaches I saw in send, testpilot, screenshots, etc.

Does it seem sane?

pdehaan · 2018-10-03T22:04:00Z

One further wrench into the plan is that the presence of a directory/file isn't always an indicator of translation %%.

In other repos (like mozilla/send) we had a script which would only include locales that are 100% translated. I think mozilla/fxa-content-server had a lower threshold (90%) before it would be considered ready for production.

pdehaan · 2018-10-03T22:08:36Z

controllers/home.js

@@ -22,7 +23,8 @@ function home(req, res) {

 function notFound(req, res) {
  res.status(404);
-  res.render("error", { message: "Page not found." });
+  const message = req.fluentBundle.format(req.fluentBundle.getMessage("notFound"));


Since this is per-user and probably not suited for app.locals.*, would it be possible to wrap this in some sort of helper function or middleware to cut down on verbosity?

function formatMessage(bundle, message) { return bundle.format(bundle.getMessage(message)); } ... const message = formatMessage(req.fluentBundle, "notFound");

pdehaan · 2018-10-03T22:09:16Z

email-utils.js

@@ -45,6 +45,7 @@ const EmailUtils = {

  sendEmail(aRecipient, aSubject, aTemplate, aContext) {
    if (!gTransporter) {
+      // TODO: l10n?


Is this message even user facing, or is this purely server logging?

pdehaan · 2018-10-03T22:11:00Z

locale-utils.js

+
+
+function loadAvailableLanguages () {
+  return fs.readdirSync( localesDir );


Not sure if this needs any footgun protection to capture stuff like .DS_Store or other files which may not be in the locales/* dir. Or if we need to add filter out any results that aren't a subdirectory, etc.

pdehaan · 2018-10-03T22:12:27Z

locale-utils.js

+function loadFluentBundles (availableLanguages) {
+  const fluentBundles = {};
+  for (const lang of availableLanguages) {
+    const langFTLSource = fs.readFileSync(path.join(localesDir, lang, "app.ftl"), "utf8");


Or if this needs to be in a try..catch to handle any folders/results which may not be a subdirectory, or there may not be an "app.ftl" file.

views/layouts/default.hbs

pdehaan · 2018-10-03T22:20:56Z

views/layouts/default.hbs

+
+    <meta name="defaultLanguage" content="en">
+    <meta name="availableLanguages" content="{{ AVAILABLE_LANGUAGES }}">
+    <link rel="localization" href="/locales/{{ locale }}/app.ftl">


Also, because we're changing the views/layouts/default.hbs template, we'll need to decide what level we want to keep that views/error-429.html template in sync (since we have-to/should update the markup in both places).

groovecoder · 2018-10-04T19:15:18Z

Addressed all comments except the template-level ones. (Still checking if we'll be able to use fluent-web for template strings, or if we'll make a handlebars helper for them.)

Consolidated some of the server start-up code into a single locale.loadLanguagesIntoApp function.

Made the pickLanguage middleware also add a fluentFormat helper on the request object, so calling code can be simplified to, e.g., req.fluentFormat("notFound")

groovecoder · 2018-10-04T19:25:56Z

The %-checking heuristic seems neat, but how helpful is it?

The fxa-content-server check just seems to check that a translated message is non-blank, which ignores up-to-date-ness of the translations; the send check for 100% no errors nor missing translations means (like you say in the PR) that any update to en-US invalidates all translations until they are back to 100%?

Either tooling tactic seems to rely on a significant amount of manual translation support anyway. Does the tooling help notify the human translators of the updates needed?

lesleyjanenorton · 2018-10-14T21:27:42Z

public/locales/en/app.ftl

+  That's good news, but data breaches can happen any time and there is still more you can do. 
+  Subscribe to Firefox Monitor for a full report, alerts when new breaches happen, and tips on protecting your passwords.
+
+featured-breach-results = 


@stasm I'm still running into some selector trouble here in "featured-breach-results". As is, this throws a "ctor is not a constructor" error. If I change [one] to [1], the string will return correctly only if the value of $breachCount is exactly 1. I'm totally puzzled as I recreated this over in the Fluent playground where it appears to be working exactly as expected. Have you run into anything like this?

This might be related to the Intl.PluralRules API. It's still a fairly new feature in JavaScript. Looking at the browser support matrix, is there a chance you're testing on Safari? In order to support Safari as well as older browsers, you'll need to polyfill Intl.PluralRules. I recommend intl-pluralrules.

Background: Fluent relies on this API to match variant keys which are not numbers. When you use [one] Fluent maps the numerical value of $breachCount to a plural category. Categories are defined in CLDR. For English, they're one and other. Other languages have fewer or more.

Aha, node.js is probably the culprit here - it doesn't have support for Intl.PluralRules API. I'll see if I can add that to our package.json and get this to work.

groovecoder · 2018-10-15T18:29:19Z

locale-utils.js

+const path = require("path");
+
+// node.js needs Intl.PluralRules polyfill
+require("intl-pluralrules");


I can't even find a good enough emoji.

Nice! Happy to hear that was it!

groovecoder · 2018-10-16T18:15:28Z

Updated to have fluentFormat add messages from all .ftl files in the in public/locales/{lang}/ directories.

flodolo · 2018-10-16T18:14:42Z

public/locales/en/app.ftl

@@ -0,0 +1,35 @@
+-product-name = Firefox Monitor


Can you add a note similar to the one in the add-on, extending it to all brands in this section?

flodolo · 2018-10-16T18:17:27Z

public/locales/en/app.ftl

+-brand-name = Firefox
+-brand-Quantum = Firefox Quantum
+-brand-Mozilla = Mozilla
+-brand-HIBP = HIBP


Please add a note to explain what HIBP stands for.

flodolo · 2018-10-16T18:18:13Z

public/locales/en/app.ftl

+# Descriptive headline for a column of links where users can give feedback, or get additional information about, Firefox Monitor.
+layout-support = Support
+# Link that takes the user to a Firefox Monitor survey. 
+give-feedback = <span class="nowrap">Give Feedback</span>


Is it possible to avoid exposing this markup to localizers (same for the next string)?

Yep, we can move this to template.

I'll remove it wherever possible. Unfortunately, for cases like L82 and a few others, it will need to remain as is.

flodolo · 2018-10-16T18:18:46Z

public/locales/en/app.ftl

+error-not-subscribed = This email address is not subscribed to {-product-name}.
+error-hibp-throttled = Too many connections to {-brand-HIBP}.
+error-hibp-connect = Error connecting to {-brand-HIBP}.
+error-hibp-load-breaches = Could not load breaches.


breaches -> data breaches?

I think L16-L18 are actually log errors and may not need to be localized at all. @groovecoder do we want to localize these?

flodolo · 2018-10-16T18:18:53Z

public/locales/en/app.ftl

+error-hibp-connect = Error connecting to HIBP.
+error-hibp-load-breaches = Could not load breaches.
+
+hibp-notify-email-subject = {-product-name} Alert : Your account was involved in a breach.


Still open question. Is it because it's the title of a web page?

flodolo · 2018-10-16T18:20:30Z

public/locales/en/app.ftl

+  And hackers rely on bad habits, like using the same password everywhere or using common phrases (p@ssw0rd, anyone?), 
+  so that if they hack one account, they can hack many. Here are six ways to protect your accounts.
+
+pwt-headline-1 = Use a Different Password for Every Account


I pointed out before that this approach doesn't scale. Group headline and summary with meaningful IDs, don't use numbers.

I think in this case the numbers are meaningful because the password tips are specifically presented in the order that they are numbered. Additionally, the tips are displayed alongside corresponding icons which are also numbered accordingly. I will happily defer to your judgement here if you think this is going to cause future problems though.

Regarding the colon spacing on L13 (for some reason I can't respond to that comment directly): We just received updated copy for the emails and the extra space has been removed.

Additionally, the tips are displayed alongside corresponding icons which are also numbered accordingly.

How is that done? Have you considered other types of numerals?

I will happily defer to your judgement here if you think this is going to cause future problems though.

Two likely scenarios:

You want to change the order.

You want to replace or update one of the tips. You'll need to change the message ID to do that.

In both cases you'll need to add a mapping afterward.

Also, strings are presented sequentially to localizers, so having title and description together help a bit.

flodolo · 2018-10-16T18:21:16Z

public/locales/en/app.ftl

+-brand-Quantum = Firefox Quantum
+-brand-Mozilla = Mozilla
+-brand-HIBP = HIBP
+-product-name-nowrap = <span class="nowrap">Firefox Monitor</span>


Wouldn't it be easier to use a non breaking space in the main brand name, and always use that?

Potentially - we've discussed this in previous pull requests and my understanding is that is deprecated and there are a11y concerns with using it.

flodolo · 2018-10-16T18:22:49Z

public/locales/en/app.ftl

+form-signup-error = Must be a valid email.
+
+
+found-breaches-headline = This could be a problem...


Use single unicode character …

flodolo · 2018-10-16T18:26:11Z

public/locales/en/app.ftl

+    }.
+
+scan-results = Your account { $breachCount ->
+    [0] Your email address did not appear in our basic scan.


@stasm @zbraniecki Thoughts on using Fluent like this, also in the previous string?

I really think we should split out the 0 case. If nothing else for practical reasons: it would be impossible to translate this in Pontoon, where there no text area for variants.

@flodolo thanks for the feedback. Is it possible to translate any variant in Pontoon, or is there a specific issue with the zero case?

Was following this example and a similar example of usage here: https://projectfluent.org/play/

This is perfectly fine Fluent, it's just tricky for localizers to understand what we're asking them to translate.

It becomes easier if we're exposing the full phrase for each variant.

There's things we'll want to do on the l10n tooling side there in the next year, but right now, the extra repetition of the head and tail section would be good.

single-featured-breach-result = Your account appeared in the { $featuredBreach } breach, but did not appear in any other known data breaches. multiple-featured-breach-results = { $breachCount -> [one] Your account appeared in the { $featuredBreach } breach, as well as { $breachCount } other breach. *[other] Your account appeared in the { $featuredBreach } breach, as well as { $breachCount } other breaches. }

@Pike thanks for the clarification

What Pike said :)

The UI looks like this. The fragment before would become another input field, and you would need to drag the input field to see everything.

To be clear, I would do this

featured-breach-no-results = Your account appeared in the { $featuredBreach } breach, but did not appear in any other known data breaches. featured-breach-results = { $breachCount -> [one] Your account appeared in the { $featuredBreach } breach, as well as { $breachCount } other breach. *[other] Your account appeared in the { $featuredBreach } breach, as well as { $breachCount } other breaches. } scan-no-results = Your email address did not appear in our basic scan. That's good news, but data breaches can happen any time and there is still more you can do. Subscribe to Firefox Monitor for a full report, alerts when new breaches happen, and tips on protecting your passwords. scan-results = { $breachCount -> [one] Your account appeared in the following breach. *[other] Your account appeared in the following { $breachCount } breaches. }

Note also that your current string would result in Your account Your email address did not appear in our basic scan. etc

I really think we should split out the 0 case. If nothing else for practical reasons: it would be impossible to translate this in Pontoon, where there no text area for variants.

From the Fluent perspective, I think using [0] like this is fine and it adds flavor to the translation. The Good Practices document has more discussion about this.

However, if Pontoon doesn't support extra variants right now, we should avoid it (for now). Sorry, @lesleyjanenorton! We'll get there eventually :)

flodolo · 2018-10-16T18:27:21Z

public/locales/en/app.ftl

+
+# copyright-info (without markup) = Portions of this content are 1998-2018 by individual mozilla.org contributors. Content available under a Creative Commons license.
+copyright-info = 
+  Portions of this content are <span class="copyright-symbol">&copy;</span> 1998-2018 by individual mozilla.org contributors. <br />


flodolo · 2018-10-17T06:00:19Z

public/locales/en/data-classes.ftl

+email-messages = Email messages
+employers = Employers
+ethnicities = Ethnicities
+family-members'-names = Family members' names


I'm pretty sure the ' in the ID is a parsing error. The string, on the other hand, should use an apostrophe ’

groovecoder · 2018-10-17T16:02:31Z

After @lesleyjanenorton's updates, I added commits to remove the test de/app.ftl file, to move public/locales to locales at the base of the repo, and to check for NODE_ENV === "heroku" to enable pontoon JS for in-page localization.

I've also pushed this branch directly to https://fx-breach-alerts.herokuapp.com/ so we can see this code running live before our upcoming meeting.

(Note: @lesleyjanenorton I'm getting error {"stack":"TypeError: dataClasses.split is not a function at Object.breachDataClasses (/Users/lcrouch/code/mozilla/blurts-server/hbs-helpers.js:28:71) on http://localhost:6060/user/verify?token=87dea900-428d-4b71-aad9-16b9ceb7ed92. Trying to track it down now.)

flodolo · 2018-10-17T16:09:58Z

to check for NODE_ENV === "heroku" to enable pontoon JS for in-page localization.

I'm not exactly sure if that works reliably, or for Fluent projects. @mathjazz ?

mathjazz · 2018-10-17T16:18:01Z

I'm not exactly sure if that works reliably, or for Fluent projects. @mathjazz ?

In theory it works, but requires additional testing. AFAICT, it hasn't been used in combination with a Fluent.

I suggest we don't block enabling localization on it and enable in-place localization as a follow-up.

groovecoder · 2018-10-17T16:19:31Z

In our case, I've specifically set NODE_ENV=heroku using heroku:config so it should work for us. Not sure what the broader NODE_ENV convention is.

I've also fixed the error on /user/verify so the text actually shows, though the page styles are messed up.

Pike · 2018-10-17T16:24:08Z

locales/en/app.ftl

+# - Declined to adapt to grammatical case.
+# - Transliterated.
+# - Translated.
+-product-name = Firefox Monitor


If you're making this Firefox{"\u00A0"}Monitor (aka nbsp), you probably get around the dom fragments and the nowrap, and that might also be good for a11y?

Filed #535 for a follow-up on this.

groovecoder · 2018-10-17T20:01:55Z

I'm merging this now, as it touches so many files and is preventing us from doing much else until it's merged.

Filed #533 for email localization, #534 for the heroku/in-page localization follow-up, #535 for   discussion & decision, and #524 to verify that @mozilla-pontoon can/will create the launch .ftl files in the repository for launch.

They are all in the l10n label now.

groovecoder force-pushed the add-fluent-for-l10n branch 4 times, most recently from 8fc7c4a to 8082cb3 Compare September 30, 2018 00:11

pdehaan reviewed Sep 30, 2018

View reviewed changes

groovecoder force-pushed the add-fluent-for-l10n branch 2 times, most recently from 0e140e5 to 29aef58 Compare October 2, 2018 15:32

groovecoder force-pushed the add-fluent-for-l10n branch 3 times, most recently from 53016bb to cb93013 Compare October 3, 2018 21:32

pdehaan reviewed Oct 3, 2018

View reviewed changes

groovecoder force-pushed the add-fluent-for-l10n branch 3 times, most recently from bb8af38 to 85a5f95 Compare October 4, 2018 19:13

groovecoder force-pushed the add-fluent-for-l10n branch 2 times, most recently from b82397e to 0734f7f Compare October 4, 2018 19:48

lesleyjanenorton reviewed Oct 14, 2018

View reviewed changes

add intl-pluralrules polyfill for fluent in node

1b0fdd4

groovecoder commented Oct 15, 2018

View reviewed changes

lesleyjanenorton and others added 2 commits October 15, 2018 14:43

More i20n updates.

396548f

fluentFormat should check all .ftl files

d87b36a

groovecoder force-pushed the add-fluent-for-l10n branch from e00ac27 to d87b36a Compare October 16, 2018 18:14

flodolo requested changes Oct 16, 2018

View reviewed changes

flodolo reviewed Oct 17, 2018

View reviewed changes

lesleyjanenorton and others added 4 commits October 17, 2018 10:28

String & Template Updates

23895f2

remove testing de/app.ftl file

27ee556

move public/locales to locales/

f836465

ENABLE_PONTOON_JS on "heroku" env

a36bf1c

groovecoder force-pushed the add-fluent-for-l10n branch from b0dc3a8 to a36bf1c Compare October 17, 2018 15:54

pass req to report.hbs for breachDataClasses helper

eced822

groovecoder temporarily deployed to fx-breach-alerts October 17, 2018 16:17 Inactive

Pike reviewed Oct 17, 2018

View reviewed changes

fix report.hbs and breach_alert.hbs data classes

4fd3317

groovecoder temporarily deployed to fx-breach-alerts October 17, 2018 19:23 Inactive

This was referenced Oct 17, 2018

i18n copy/text/messages of emails #533

Closed

Enable in-page localization on heroku #534

Closed

Make final decision between   \u00A0 or class="nowrap" #535

Closed

Add l10n launch languages to public/locale #524

Closed

groovecoder merged commit c721f33 into master Oct 17, 2018

groovecoder deleted the add-fluent-for-l10n branch October 17, 2018 20:04


		terms = Terms and Privacy

		copyright = Portions of this content are © 1998-2018 by individual mozilla.org contributors. Content available under a Creative Commons license


		terms = Allgemeine Geschäftsbedingungen und Datenschutzerklärung

		copyright = Teile dieses Inhalts sind © 1998-2018 von einzelnen mozilla.org-Mitwirkenden. Inhalt verfügbar unter einer Creative Commons-Lizenz



		function loadAvailableLanguages () {
		return fs.readdirSync( localesDir );

		form-signup-error = Must be a valid email.


		found-breaches-headline = This could be a problem...

WIP: start l10n tooling #486

WIP: start l10n tooling #486

Conversation

groovecoder commented Sep 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stasm commented Oct 1, 2018

pdehaan commented Oct 1, 2018

groovecoder commented Oct 2, 2018

zbraniecki commented Oct 2, 2018

groovecoder commented Oct 2, 2018

groovecoder commented Oct 2, 2018

groovecoder commented Oct 2, 2018

groovecoder commented Oct 3, 2018

pdehaan commented Oct 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

groovecoder commented Oct 4, 2018

groovecoder commented Oct 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

groovecoder commented Oct 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesleyjanenorton Oct 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flodolo Oct 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flodolo Oct 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

groovecoder commented Oct 17, 2018

flodolo commented Oct 17, 2018

mathjazz commented Oct 17, 2018

groovecoder commented Oct 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

groovecoder commented Oct 17, 2018

groovecoder commented Sep 29, 2018 •

edited

Loading

lesleyjanenorton Oct 16, 2018 •

edited

Loading

flodolo Oct 16, 2018 •

edited

Loading

flodolo Oct 17, 2018 •

edited

Loading