Trigger different events with different data for file vs. folder renames #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| oldPath: "/path/before/rename", | ||
| newPath: "/path/after/rename", | ||
| // Paths to all files contained inside the folder being renamed |
There was a problem hiding this comment.
s/files/child paths/ since it might also include folder names.
There was a problem hiding this comment.
it won't include folder names since we explicitly ignore them
|
This looks generally OK to me. A couple things I wasn't sure about listed in the PR. r=me |
|
This is good, r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch treats file renames and folder renames as different events.
fileRenameevent and send the old file path and the new file path (nothing has changed here)folderRenameevent and send only one object that contains the old folder path, the new folder path and an array of relative paths of files that live in the folder that is about to be renamed.This will allow us to fix mozilla/thimble.mozilla.org#1311 and is part of a 3-piece patch (this patch depends on a patch in publish.wm.org landing first that adds a route for folder renames, then this patch should be landed along with the corresponding patch in thimble.mozilla.org). I haven't tested this yet since I'm waiting on another patch in publish to land first before I write the patch that will add the folder rename route...then I can test this.
@humphd r?