Reordering containers in Manage Containers doesn't apply to other Firefox menus

[emyarod]

• Multi-Account Containers Version: 7.3.0
• Operating System + Version: Windows 10, macOS, Linux
• Firefox Version: 87 Nightly

Actual behavior

as reported by @hub2git in #330

After updating to Firefox 85.0 on Linux, I now can sort the containers -- as they appear in the toolbar -- by drag and drop.

But the changes are not reflected when right-clicking a link on a webpage and hovering over "Open Link in New Container Tab".

Expected behavior

order of containers in right click context menu should match order in the toolbar

Steps to reproduce

1. reorder containers
2. observe that the order of containers differs between the context menu and toolbar dropdown

[hub2git]

@emyarod thanks for creating this new issue and for mentioning me.

[jonathanKingston]

Duplicate of: https://bugzilla.mozilla.org/show_bug.cgi?id=1333395

[achernyakevich-sc]

I have decided to provide screenshot that visually explain the problem:

[Karl-MCS]

If you click the Multi-Account Containers toolbar button and click Manage Containers, you can re-order the containers manually by drag-and-drop. However, in all other menus (long-click/right-click + tab button, right-click tab or link and hover Open in New Container Tab) the containers retain their original unsorted order in which they were created.

[jlaundry]

So I had a quick look at this, link to WIP: main...jlaundry:multi-account-containers:main#files

Always open this in a Container (URL bar icon) is relatively easy - we can just create a getIdentities() function in Utils.js, replicate the behaviour from Logic.refreshIdentities(), and use this instead of a direct const identities = browser.contextualIdentities.query({})

Open in a New Container Tab (tab right-click menu) and Container Tabs (Settings page) seem to be tricker... I've tried brute-forcing it by find/replacing with Utils.getIdentities() everywhere, but that doesn't seem to have any effect. I suspect, given the l10n strings are in mozilla-central, that this may be outside this extension? But not sure (I'm just a Firefox fan, not usually a dev!)

[groovecoder]

The fix for this has been released. #2672