Fix missing i18n strings in the UI #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycolin
force-pushed
the
i18n-remove-hardcoded-strings
branch
4 times, most recently
from
612ec45 to
9534e78
Compare
dannycolin
force-pushed
the
i18n-remove-hardcoded-strings
branch
from
9534e78 to
a198cf0
Compare
This patch fix all the missing i18n strings in the UI. It also standardize the main title to "Firefox Multi-Account Containers" everywhere we use it in the addon.
dannycolin
force-pushed
the
i18n-remove-hardcoded-strings
branch
from
a198cf0 to
f85d751
Compare
groovecoder
requested changes
Jun 21, 2023
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Jun 26, 2023
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Jun 26, 2023
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Jun 26, 2023
groovecoder
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix all the missing i18n strings in the UI. It also standardize the main title to "Firefox Multi-Account Containers" everywhere we use it in the addon.
In
src/js/background/backgroundLogic.js, we update the i18n strings for the open_container_[0-9] commands on startup and on install. This is done to avoid using both an hardcoded value with a i18n strings (e.g__MSG_myMessage__ my extra text). See mozilla-l10n/multi-account-containers-l10n#23