Revert monitoring modifier in popup shortcuts #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nomes77
added a commit
to Nomes77/multi-account-containers
that referenced
this pull request
Oct 17, 2023
maxxcrawford
approved these changes
Nov 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression in our shortcut listener. The previous patch was listening if a modifier was pressed in order to prevent conflicts with Firefox builtin shortcuts. However, the implementation had a side effect of preventing the insertion of characters from a key combination including a modifier.
You can test this fix by trying to insert characters like
@or:. Also, you can test to pressshift + 1to see the behavior I'm considering a conflict with Firefox. The addon popup stays open while the focus is now a newly opened tab.Note: The conflict with Firefox builtin shortcuts existed prior to both the patch already landed in main and this fix so it doesn't remove any functionality.
Type of change
Select all that apply.