-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICC profiles support for images #2856
Comments
The HTML site shows version 2 support only in here (windows 7 x64, firefox aurora), is this something new to windows 8? |
SumatraPDF doesn't support those profiles either, so I wonder how important the support really is? |
ICCv4 is disabled by default in Firefox, you have to flip gfx.color_management.enablev4 to True |
I don't know how important it is, but I couldn't find any relevant bug, so I made a new one with links to test cases. |
Yeah it's okay, better to have a tracking bug. Worst case the devs would close as "won't fix", best case it gives some dev or contributor something to do ;P |
I don't know if it works, but if it can help someone to implement ICC profiles, I found this: |
Frankly it's a bit ridiculous that Firefox's PDF viewer (PDF.js) still lacks support for both v2 and v4 profiles in the year 2020. 😠 👎 |
Seems that even Chrome doesn't support v4 profile. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
Ive written an ICC engine in Javascript, It can read V2 and V2 color profiles, takes around 40ms to build a 33x33x33 LUT and CMYK>RGB via Uint8ClampedArray is in the order of 20-30 million PIXELS per second, Its not public yet, let me know if anyone is interested in me releasing the code. |
Chrome supports v4 now. Same for Edge and iOS PDF viewer when I tested. |
I released my Javascript ICC color engine here: https://www.npmjs.com/package/jscolorengine. I don't have time to implement it in PDFJS, but someone else might be able to look into it, however I believe its only halfway as there might be need to implement Type 1 Color Rendering Dictionary, however there is groundwork in my code for handling all of this. |
This comment was marked as duplicate.
This comment was marked as duplicate.
I'm attaching the test file from comment 0 here: |
Right now pdf.js ignores embedded color profiles of any kind.
Here's a test pdf that looks just fine with Windows Reader on Windows 8, but shows no support in PDF.js.
And yes, Firefox does work (same test, but as html: http://www.color.org/version4html.xalter)
The text was updated successfully, but these errors were encountered: