Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Default fill color for rectangle is transparent #13548

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

calixteman
Copy link
Contributor

The issue is visible in pdf in #13213 (some black rectangles are displayed).

@calixteman calixteman requested a review from brendandahl June 11, 2021 16:05
let propName = "color";
if (parent instanceof Border) {
propName = "background";
}
if (parent instanceof Rectangle) {
if (parent instanceof Rectangle || parent instanceof Arc) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Arc needed for the same PDF? Or is it a defensive change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep it is.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b6bd478d394f2e7/output.txt

@timvandermeij
Copy link
Contributor

@calixteman The Windows bot seems to be unavailable since yesterday, and it's also missing here. Could you restart it?

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/b6bd478d394f2e7/output.txt

Total script time: 26.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/b6bd478d394f2e7/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/76f12284a769ca3/output.txt

@calixteman
Copy link
Contributor Author

@calixteman The Windows bot seems to be unavailable since yesterday, and it's also missing here. Could you restart it?

Done.
The vm has rebooted by itself, I don't know why... anyway I just restarted the bot.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/76f12284a769ca3/output.txt

Total script time: 30.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/76f12284a769ca3/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 96c1034 into mozilla:master Jun 13, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3c9382d17ae10af/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/6fcda3c21b3a0e7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/3c9382d17ae10af/output.txt

Total script time: 23.66 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/6fcda3c21b3a0e7/output.txt

Total script time: 26.73 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij removed the request for review from brendandahl June 13, 2021 13:08
@calixteman calixteman deleted the default_fill branch June 13, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants