Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check more of the stream when looking for commands after inline image (issue 19494) #19495

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Check more of the stream when looking for commands after inline image (issue 19494) #19495

merged 1 commit into from
Feb 15, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

Currently we only check followingBytes, which turns out to be too short to find e.g. valid transform (cm) commands with decimal arguments.

@Snuffleupagus
Check more of the stream when looking for commands after inline image…
65df1d3 
… (issue 19494)

Currently we only check `followingBytes`, which turns out to be too short to find e.g. valid transform (cm) commands with decimal arguments.
@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/50922f5068355dd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/13028d16e996d6e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/50922f5068355dd/output.txt

Total script time: 17.08 mins

  • Regression tests: Passed

@Snuffleupagus Snuffleupagus linked an issue Feb 15, 2025 that may be closed by this pull request
[Bug]: Inline image not rendered #19494
Closed
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/13028d16e996d6e/output.txt

Total script time: 30.18 mins

  • Regression tests: Passed

calixteman
calixteman approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 3f15e0c into mozilla:master Feb 15, 2025
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/50104b4253b5ffc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/648354d8d6a64c9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/50104b4253b5ffc/output.txt

Total script time: 16.69 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/648354d8d6a64c9/output.txt

Total script time: 30.20 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-19494 branch February 15, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Inline image not rendered
3 participants
@Snuffleupagus @moz-tools-bot @calixteman