-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten the CipherTransformFactory.prototype.#buildObjectKey
method
#19496
Shorten the CipherTransformFactory.prototype.#buildObjectKey
method
#19496
Conversation
- Use `TypedArray.prototype.set()` rather than a manual loop when building the `key`. - Use an existing local variable to avoid re-computing the length of the `encryptionKey`.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8dbfafad3d127d7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8d3a7377d42617b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8dbfafad3d127d7/output.txt Total script time: 2.42 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8d3a7377d42617b/output.txt Total script time: 7.59 mins
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c1807fb932372ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1d8db350ef6f7e8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c1807fb932372ae/output.txt Total script time: 16.70 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1d8db350ef6f7e8/output.txt Total script time: 29.98 mins
|
Use
TypedArray.prototype.set()
rather than a manual loop when building thekey
.Use an existing local variable to avoid re-computing the length of the
encryptionKey
.