Ensure that the useWorkerFetch fallback value is always a boolean
#19499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
useWorkerFetch fallback value is always a booleanuseWorkerFetch fallback value is always a boolean
If either of the factory-urls are missing or invalid, the fallback value would currently become `useWorkerFetch === null`. While that is obviously a falsy value, which means that the code still works as intended, we should ensure that this is consistent.
Snuffleupagus
force-pushed
the
useWorkerFetch-ensure-boolean
branch
from
79a7dc0 to
06e4580
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/14bcf0451080974/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/296d66d1c118244/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/14bcf0451080974/output.txt Total script time: 2.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/296d66d1c118244/output.txt Total script time: 7.45 mins
|
timvandermeij
approved these changes
Feb 16, 2025
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If either of the factory-urls are missing or invalid, the fallback value would currently become
useWorkerFetch === null.While that is obviously a falsy value, which means that the code still works as intended, we should ensure that this is consistent.