-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Skip throwing actions #19508
[JS] Skip throwing actions #19508
Conversation
It fixes mozilla#19505. We were invaliding throwing actions (in setting event.rc to false) and all the event process was stopped. Now we're just dumping the exception in the console: the action is skipped and event.rc is not set else the input fields aren't updated wit KeyStroke actions.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/91035546c57a8fa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e145d7e4d7175b7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/91035546c57a8fa/output.txt Total script time: 10.92 mins
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/63307e27cd2814d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/293627b3c83ef06/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/63307e27cd2814d/output.txt Total script time: 2.37 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e145d7e4d7175b7/output.txt Total script time: 25.92 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/293627b3c83ef06/output.txt Total script time: 7.42 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
It fixes #19505.
We were invaliding throwing actions (in setting event.rc to false) and all the event process was stopped. Now we're just dumping the exception in the console: the action is skipped and event.rc is not set else the input fields aren't updated wit KeyStroke actions.