-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the EXIF-block replacement into JpegStream
(PR 19356 follow-up)
#19518
Move the EXIF-block replacement into JpegStream
(PR 19356 follow-up)
#19518
Conversation
Currently we modify the EXIF-block in place, which may end up "breaking" the JPEG-data of the original PDF document since e.g. saving it from the viewer no longer contains the real EXIF-block. Hence the EXIF-block replacement is moved into the `JpegStream` class, such that we can copy the data before doing the replacement.
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/27915683e4f7d15/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/dd80f23dd852806/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/dd80f23dd852806/output.txt Total script time: 2.37 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/27915683e4f7d15/output.txt Total script time: 7.29 mins
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d64530f95673390/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e9b7bc9b28ab7a9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d64530f95673390/output.txt Total script time: 17.06 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e9b7bc9b28ab7a9/output.txt Total script time: 30.02 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Currently we modify the EXIF-block in place, which may end up "breaking" the JPEG-data of the original PDF document since e.g. saving it from the viewer no longer contains the real EXIF-block.
Hence the EXIF-block replacement is moved into the
JpegStream
class, such that we can copy the data before doing the replacement.