Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to viewer to support progressive loading #2914

Merged
merged 1 commit into from
Mar 29, 2013

Conversation

mduan
Copy link
Contributor

@mduan mduan commented Mar 9, 2013

Separates out some of the viewer changes from #2719.

These changes make it so that the viewer can load and draw pages separately, rather than requiring all pages before drawing.

@mduan
Copy link
Contributor Author

mduan commented Mar 9, 2013

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

From: Bot.io (Windows)


Received

Command cmd_test from @mduan received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7412653db99d467/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

From: Bot.io (Linux)


Received

Command cmd_test from @mduan received. Current queue size: 0

Live output at: http://107.21.233.14:8877/259fcc66de67150/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/259fcc66de67150/output.txt

Total script time: 20.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/7412653db99d467/output.txt

Total script time: 20.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/19dbe1f928b8d2e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2013

defaultViewportPromise.resolve(viewport);
});

defaultViewportPromise.then(function(viewport) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this promise needed? It looks like all of this code could just be moved up to where it is resolved above, which would take out a layer of indirection.

@yurydelendik
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a38aeacdd693076/output.txt

@pdfjsbot
Copy link

@yurydelendik
Copy link
Contributor

Pages rotation is broken. Otherwise looks fine.

@mduan
Copy link
Contributor Author

mduan commented Mar 28, 2013

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @mduan received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e8a23b346404932/output.txt

@pdfjsbot
Copy link

@mduan
Copy link
Contributor Author

mduan commented Mar 29, 2013

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @mduan received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b4c5c6f0fdbd596/output.txt

@pdfjsbot
Copy link

yurydelendik added a commit that referenced this pull request Mar 29, 2013
Changes to viewer to support progressive loading
@yurydelendik yurydelendik merged commit 9b0714a into mozilla:master Mar 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants