-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to viewer to support progressive loading #2914
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @mduan received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7412653db99d467/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @mduan received. Current queue size: 0 Live output at: http://107.21.233.14:8877/259fcc66de67150/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/259fcc66de67150/output.txt Total script time: 20.26 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7412653db99d467/output.txt Total script time: 20.83 mins
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/19dbe1f928b8d2e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/19dbe1f928b8d2e/output.txt Total script time: 0.22 mins Published |
defaultViewportPromise.resolve(viewport); | ||
}); | ||
|
||
defaultViewportPromise.then(function(viewport) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this promise needed? It looks like all of this code could just be moved up to where it is resolved above, which would take out a layer of indirection.
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a38aeacdd693076/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a38aeacdd693076/output.txt Total script time: 0.25 mins Published |
Pages rotation is broken. Otherwise looks fine. |
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @mduan received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e8a23b346404932/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e8a23b346404932/output.txt Total script time: 0.21 mins Published |
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @mduan received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b4c5c6f0fdbd596/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b4c5c6f0fdbd596/output.txt Total script time: 0.25 mins Published |
Changes to viewer to support progressive loading
Separates out some of the viewer changes from #2719.
These changes make it so that the viewer can load and draw pages separately, rather than requiring all pages before drawing.