Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shell to use Context.VERSION_ES6 by default (instead of Context.VERSION_1_8) #1279

Closed
p-bakker opened this issue Nov 10, 2022 · 2 comments · Fixed by #1594
Closed

Comments

@p-bakker
Copy link
Collaborator

Any objections?

@MaxisTekfield
Copy link
Contributor

Sounds good.

@TheRohinth
Copy link

Hi @p-bakker , Greetings for the day.

I look forward for this enhancement of using Context.VERSION_ES6 by default.
When will this be completed ?
Will this enhancement be delivered in the next version of rhino ?

As I need to use Promises in Rhino-1.7.14

  1. I can't just add rhino in dependencies task
  2. I need to execute rhino with -version 200 in order to make it support promises
  3. but I couldn't configure the -version flag for the same in build.gradle.

I tried to create a task in build.gradle which has the type "JavaExec" that executes the rhino-1.7.14.jar with
"-version 200" argument. But it did not help.

Do you think this approach would help me ?
If yes, Could you help me with this approach ?
(if this works out, it will be helpful for me until Context.VERSION_ES6 is made default)

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants