Remove obsolete "ObjArray" class #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on context, replace this venerable class with either ArrayList or ArrayDeque.
|
+1 |
p-bakker
added
the
Potentially Breaking Change
|
Although ObjArray was a public class, I've got no problem removing it Tagged this PR with the `potentially breaking change' label, so we won't forget to add a note to the 1.7.16 release notes about is removal |
|
Sure, I don't mind being super-pedantic and letting people know that we are deleting a public class. Realistically, I seriously doubt that anyone is using this class. (Next, I plan to get rid of ObjToIntMap and UIntMap which I suspect will have similar issues!) Anyway, this has been pretty uncontroversial so I'm going to merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on context, replace this venerable class with either ArrayList or ArrayDeque.
This is the first of a few PRs to get rid of some of the more obsolete things in the codebase.