-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Localization #57
Comments
Nevermind, they're a web-ext, we aren't. |
Added l20n in #245 |
@flodolo This project is ready for adding to Pontoon we think |
https://github.com/mozilla/send/tree/master/public/locales is the directory. is that an ok location or does it need to be in the root? |
CC @mathjazz I'm pretty sure locales doesn't need to be in the root, but that structure is wrong en-US should be a folder, and disappear from the filename. The whole file needs to be reviewed, and comments added. Not completely sure how to do that efficiently. Maybe remove the file completely, and open a PR with the correct structure and filename so I can comment? Also, there are a ton more information I need before enabling a project in Pontoon:
|
Also cc @stasm and @Pike. A few notes from a quick look at the FTL file, to speed up the review later. As said, I think the easiest way is to remove the add the correct FTL in a pull request and use that to comment. nit: use 4 spaces instead of 2 when indenting attributes. Do you really need this?
It should probably just be
These don't look like titles, let's find better string IDs. This
Should be
Unless strictly necessarily, don't reuse strings like this. |
We'll also need a top-level Also, for now please make sure that your file passes through https://github.com/projectfluent/python-fluent/blob/master/tools/fluentfmt.py, 'cause otherwise our toolchains can create weird and buggy output. |
@flodolo I will submit a PR with a revised file today. |
Here's the description that I've put in the Info section in Pontoon. I'm going to enable the project in a few minutes on prod (tested a commit on stage already).
Let me know if you have amends. |
@dannycoates |
Yeah, we'll need to set different |
???
The text was updated successfully, but these errors were encountered: