refactored ftl file #269

abhinadduri · 2017-07-20T22:51:12Z

No description provided.

dannycoates · 2017-07-20T23:29:36Z

ref #57

dannycoates · 2017-07-21T00:07:01Z

@flodolo r?

flodolo

CC @Pike and @stasm

Can you add a l10n.toml file too as suggested in #57 (comment)?

More questions, because GitHub is a smart-ass and I can't comment on the entire file (didn't think of that):

Is "Firefox Send" a brand? Can it be localized? If not, we should probably not expose that string and hard code it.
"your stuff" in uploadPageExplainer: this sounds way too colloquial in a shipping product?

Final question: how final are these strings? Do they need to go through PM/Legal approval? If they do, we should wait before exposing them for localization.

flodolo · 2017-07-21T06:21:46Z

public/locales/en-US/send.ftl

@@ -7,7 +7,7 @@ uploadPageLearnMore = Learn more
 uploadPageDropMessage = Drop your file here to start uploading
 uploadPageSizeMessage = For the most reliable operation, it’s best to keep your file under 1GB
 uploadPageBrowseButton = Select a file on your computer


Do you actually need the string on the entity, or only on the title attribute? If it's the former, this should be

uploadPageBrowseButton .title = Select a file on your computer

Same question for similar strings.

We need the string on the entity as well.

OK. @mathjazz is this going to work without issues in Pontoon?

flodolo · 2017-07-21T06:26:33Z

public/locales/en-US/send.ftl

@@ -19,66 +19,70 @@ notifyUploadDone = Your upload has finished.

 uploadingPageMessage = Once your file uploads you will be able to set expiry options.
 uploadingPageCancel = Cancel upload
-  .title = {uploadingPageCancel}
+  .title = Cancel upload
 uploadCancelNotification = Your upload was cancelled.

 uploadingPageLargeFileMessage = This file is large and may take awhile to upload. Sit tight!


Pretty sure "awhile" -> "a while"

flodolo · 2017-07-21T06:27:20Z

public/locales/en-US/send.ftl

-
-//Note the spec suggests that this string is editable. That feature will not appear at Launch
+uploadSvgAlt
+    .alt = Upload
 uploadSuccessTimingHeader = The link to your file will expire after 1 download or in 24 hours.
 copyUrlFormLabel = Copy and share the link to send your file:
 copyUrlFormLabelWithName = Copy and share the link to send your file: { $filename }


What's the difference between these two strings?

Can you show me a screenshot of these two strings? I'm not sure I understand how and when they would be used, e.g. the first has a colon because it's followed by something?

copyUrlFormLabel is only being used in one place. I refactored that line so we can safely remove this string now.

flodolo · 2017-07-21T06:27:59Z

public/locales/en-US/send.ftl


-downloadAltText.alt = Download
+downloadAltText


Is this an alt text on a button or link? We need a comment to explain it's an action, not a noun

It's an alt text on an svg element. I'll go ahead and add in a comment.

flodolo · 2017-07-21T06:29:04Z

public/locales/en-US/send.ftl


-downloadAltText.alt = Download
+downloadAltText
+    .alt = Download
 downloadFileName  = Download { $filename }
 downloadFileSize = ({ $size })


Where does size come from and how it's formatted?

The file size comes in from the server and is rendered through handlebars to the ftl file. It's a string in a human readable format, i.e. 12 Mb.

flodolo · 2017-07-21T06:29:29Z

public/locales/en-US/send.ftl

 downloadFileName  = Download { $filename }
 downloadFileSize = ({ $size })
 downloadMessage = Your friend is sending you a file with Firefox Send, a service that allows you to share files with a safe, private, and encrypted link that automatically expires to ensure your stuff does not remain online forever.
 downloadButtonLabel = Download
-  .title = {downloadButtonLabel}
+    .title = Download
 downloadNotification = Your download has completed.
 downloadFinish = Download Complete

 sendYourFilesLink = Try Firefox Send


Needs a note in case Firefox Send should not be localized

flodolo · 2017-07-21T06:30:01Z

public/locales/en-US/send.ftl

 errorPageHeader = Something went wrong!
 errorPageMessage = There has been an error uploading the file.
 errorPageLink = Send another file


-linkExpiredAlt.alt = Link expired
+linkExpiredAlt
+    .alt = Link expired
 expiredPageHeader = This link has expired or never existed in the first place!
 notSupportedHeader = Your browser is not supported.
 notSupportedDetail = Unfortunately this browser does not support the web technology that powers Firefox Send. You'll need to try another browser. We recommend Firefox!


Nit: proper apostrophe instead of straight quote.

Note about Firefox Send if needed.

flodolo · 2017-07-21T06:30:52Z

public/locales/en-US/send.ftl

-
+uploadedFile = File
+copyFileList = Copy URL
+expiryFileList = Expires In


How is this string used? It smells of contenation

flodolo · 2017-07-21T06:32:34Z

public/locales/en-US/send.ftl

+uploadedFile = File
+copyFileList = Copy URL
+expiryFileList = Expires In
+deleteFileList = Delete
 nevermindButton = Nevermind


"Never mind"?

abhinadduri · 2017-07-21T15:52:20Z

@flodolo Is there any documentation on the l10n.toml file you're mentioning? I'm looking at the linked toml file and I'm not too sure how to translate it to Send. Thanks!

flodolo · 2017-07-21T15:56:20Z

http://moz-l10n-config.readthedocs.io/en/latest/fileformat.html

It should be basically identical, with public/locales instead of locales, and I guess we can drop the [locales] section for now.

abhinadduri · 2017-07-21T17:57:32Z

@flodolo I have added in the requested changes and the toml file. Please let me know if there are any more changes I need to make. Thanks.

flodolo · 2017-07-21T17:58:06Z

public/locales/en-US/send.ftl

 downloadButtonLabel = Download
    .title = Download
 downloadNotification = Your download has completed.
 downloadFinish = Download Complete

+// We might not need to localize this if it's a brand name.


You need to answer this question and a comment with the answer ;-)

Whoops... @wresuolc what are your thoughts on this?

flodolo · 2017-07-21T17:58:36Z

public/locales/en-US/send.ftl

@@ -43,16 +44,21 @@ deleteFileButton = Delete file
 sendAnotherFileLink = Send another file
    .title = Send another file

+// This alt text and the download filename string are actions.


Alternative text used on the download link/button (indicates an action).

flodolo · 2017-07-21T17:59:08Z

public/locales/en-US/send.ftl

 downloadFileSize = ({ $size })
 downloadMessage = Your friend is sending you a file with Firefox Send, a service that allows you to share files with a safe, private, and encrypted link that automatically expires to ensure your stuff does not remain online forever.
+
+// This is also an action.


Alternative text used on the download link/button (indicates an action).

(localizers don't see the whole file, only one string at a time)

flodolo · 2017-07-21T18:00:14Z

What about the question on copy/legal review? Also, as explained in a comment, you need to answer the question "Is Firefox Send a brand name and should not be localized?".

flodolo · 2017-07-21T18:04:58Z

public/locales/en-US/send.ftl

-sentFilesTitle4 = Delete
+uploadedFile = File
+copyFileList = Copy URL
+expiryFileList = Expires In


What is this string followed by?

The Expires In is a column header. It isn't followed by anything, but there are times listed below it (one for each file).

OK, can you add a comment explaining that? As simple as

// expiryFileList is used as a column header

P.S. I'm in EU timezone, I'll probably catch up next week with this

Sure thing. Thanks for all the suggestions!

abhinadduri · 2017-07-21T21:05:48Z

I have added comments stating that Firefox Send and Test Pilot do not be localized, as they are proper names.

Pike

Thanks for the l10n.toml, the file works great.

For send.ftl, we'll need some formatting changes still, please make sure that https://github.com/projectfluent/python-fluent/blob/master/tools/fluentfmt.py round-trips your ftl file without a change.

flodolo

@Pike do we care about blank lines between strings?

flodolo · 2017-07-23T15:21:00Z

public/locales/en-US/send.ftl

@@ -19,68 +20,82 @@ notifyUploadDone = Your upload has finished.

 uploadingPageMessage = Once your file uploads you will be able to set expiry options.
 uploadingPageCancel = Cancel upload
-  .title = {uploadingPageCancel}
+  .title = Cancel upload


4 spaces indentation

flodolo · 2017-07-23T15:21:21Z

public/locales/en-US/send.ftl

-downloadAltText.alt = Download
+// Alternative text used on the download link/button (indicates an action).
+downloadAltText
+    .alt = Download
 downloadFileName  = Download { $filename }


One space before =

Fixed, thanks!

Pike · 2017-07-23T18:48:45Z

@Pike do we care about blank lines between strings?

I'm afraid we do right now.

flodolo · 2017-07-24T10:16:31Z

A few more questions that I need answered before opening up the project on Pontoon:

Is there a stage/dev server? Will it be updated automatically with updated localizations? How often?
Are there deadlines?
How often will production be updated with new localizations?

abhinadduri · 2017-07-24T16:05:11Z

@dannycoates Any idea on localization deadlines and update times?

abhinadduri · 2017-07-24T16:06:22Z

@flodolo So should I remove all line breaks from the ftl file?

flodolo · 2017-07-24T16:17:46Z

@flodolo So should I remove all line breaks from the ftl file?

Empty lines, yes. You can try running the script above on your FTL file
https://github.com/projectfluent/python-fluent/blob/master/tools/fluentfmt.py

dannycoates · 2017-07-24T16:20:07Z

We have no deadlines since we can deploy as translations are completed.

dev site: https://send.dev.mozaws.net (updated automatically on each push to master)
stage site: https://send.stage.mozaws.net (updated automatically on version tag)
production site: https://send.firefox.com (updated manually after stage)

We're able to deploy translations to production at any time, but likely with new versions once a week.

flodolo · 2017-07-24T16:25:56Z

Can you also add write access to https://github.com/mozilla-pontoon?

Once the file has been updated and merged, I'll try setting up Pontoon on stage tomorrow and check that everything works as expected.

dannycoates · 2017-07-24T16:26:54Z

Can you also add write access to https://github.com/mozilla-pontoon?

done 👍

abhinadduri · 2017-07-24T16:27:18Z

@flodolo I removed the empty lines and am running the script, which seems to be outputting the same ftl as the input file. However, there's also an extra newline at the end of the python program's output: will this be an issue?

flodolo · 2017-07-24T16:32:11Z

Let's keep the same output, so empty line at the end of the file.

flodolo · 2017-07-24T16:39:24Z

One more note: once we start localizing, rule for string changes is the same as Firefox
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

flodolo

Please use a single … instead of ... (3 dots)

flodolo · 2017-07-25T16:41:01Z

public/locales/en-US/send.ftl

 fileTooBig = That file is too big to upload. It should be less than { $size }.
-
 linkExpiredAlt.alt = Link expired


This needs to be updated

Just fixed this!

abhinadduri · 2017-07-25T16:57:27Z

@flodolo I've added in the requested changes above. The latest push has an ftl file that matches the output of running fluentfmt.py on the file. Please let me know if there are more changes that need to be made before this merges into maser. Thanks so much!

flodolo

Let's merge this one, so I can test Pontoon (not sure I'll manage today, tomorrow is more likely).

refactored ftl file

2c77d94

flodolo reviewed Jul 21, 2017

View reviewed changes

abhinadduri added 2 commits July 21, 2017 10:39

added toml file

47fd387

adding requested changes

8ebfaf9

flodolo reviewed Jul 21, 2017

View reviewed changes

abhinadduri added 3 commits July 21, 2017 11:10

more fixes

28e496f

added comment to expiry column header

b123b73

Firefox Send and Test Pilot should not be localized

168a711

Pike suggested changes Jul 23, 2017

View reviewed changes

flodolo reviewed Jul 23, 2017

View reviewed changes

removed empty lines

eb73dbf

flodolo mentioned this pull request Jul 25, 2017

added legal page #291

Merged

abhinadduri added 2 commits July 25, 2017 09:23

merging master

330da9b

removing bundle files

4065bbc

dannycoates approved these changes Jul 25, 2017

View reviewed changes

flodolo suggested changes Jul 25, 2017

View reviewed changes

fixed issues, fluentfmt output matches

10d489f

flodolo approved these changes Jul 25, 2017

View reviewed changes

abhinadduri merged commit 1bfa632 into master Jul 25, 2017

dannycoates deleted the ftlFixes branch July 31, 2017 21:38

		fileTooBig = That file is too big to upload. It should be less than { $size }.

		linkExpiredAlt.alt = Link expired


		downloadAltText.alt = Download
		downloadAltText

refactored ftl file #269

refactored ftl file #269

Conversation

abhinadduri commented Jul 20, 2017

dannycoates commented Jul 20, 2017

dannycoates commented Jul 21, 2017

flodolo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhinadduri commented Jul 21, 2017

flodolo commented Jul 21, 2017

abhinadduri commented Jul 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flodolo commented Jul 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhinadduri commented Jul 21, 2017

Pike left a comment

Choose a reason for hiding this comment

flodolo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pike commented Jul 23, 2017

flodolo commented Jul 24, 2017

abhinadduri commented Jul 24, 2017

abhinadduri commented Jul 24, 2017

flodolo commented Jul 24, 2017

dannycoates commented Jul 24, 2017

flodolo commented Jul 24, 2017

dannycoates commented Jul 24, 2017

abhinadduri commented Jul 24, 2017

flodolo commented Jul 24, 2017

flodolo commented Jul 24, 2017

flodolo left a comment

Choose a reason for hiding this comment

flodolo Jul 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhinadduri commented Jul 25, 2017

flodolo left a comment

Choose a reason for hiding this comment

flodolo left a comment •

edited

Loading

flodolo commented Jul 21, 2017 •

edited

Loading

flodolo Jul 25, 2017 •

edited

Loading