This repository has been archived by the owner on May 22, 2021. It is now read-only.
add alert when uploading multiple files #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycoates
reviewed
Jul 19, 2017
| @@ -4,10 +4,11 @@ uploadPageHeader = Private, Encrypted File Sharing | |||
| uploadPageExplainer = Send files through a safe, private, and encrypted link that automatically expires to ensure your stuff does not remain online forever. | |||
|
|
|||
| uploadPageLearnMore = Learn more | |||
| uploadPageDropMessage = Drop your files here to start uploading | |||
| uploadPageDropMessage = Drop your file here to start uploading | |||
There was a problem hiding this comment.
Once we have other translations we'll need to change the key when we need to make changes to the string like this. For example if we were to change it back to "files" in v2 we'd rename the key to something likeuploadPageDropMultipleMessage or uploadPageDropMessage2.
dannycoates
reviewed
Jul 19, 2017
frontend/src/upload.js
Outdated
| file = event.originalEvent.dataTransfer.files[0]; | ||
| } else { | ||
| if (event.target.files.length > 1){ |
There was a problem hiding this comment.
I don't think this case will ever happen as long as we don't have multiple on the input element, but there's no harm in checking here too.
There was a problem hiding this comment.
That's true, I can remove that check.
ericawright
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
Fixes #248