Fix some missing .title attributes in dev-only locales #358
Conversation
| @@ -15,6 +16,7 @@ encryptingFile = Şifreleniyor... | |||
| decryptingFile = Şifre çözülüyor... | |||
There was a problem hiding this comment.
Also spotted a few of these... I think @flodolo generally recommends a single … entity versus 3 separate ....
I can manually fix those up in a separate PR or commit if anybody wants it.
A quick git grep "\.\.\." public/locales/*/*.ftl shows about 51 instances:
public/locales/cy/send.ftl:encryptingFile = Wrthi'n amgryptio...
public/locales/de/send.ftl:decryptingFile = Wird entschlüsselt...
public/locales/dsb/send.ftl:importingFile = Importěrujo se...
public/locales/dsb/send.ftl:verifyingFile = Pśespytujo se...
public/locales/dsb/send.ftl:encryptingFile = Koděrujo se...
public/locales/dsb/send.ftl:decryptingFile = Dešifrěrujo se...
public/locales/es-ES/send.ftl:importingFile = Imporando...
public/locales/es-ES/send.ftl:verifyingFile = Comprobando...
public/locales/es-ES/send.ftl:encryptingFile = Encriptando...
public/locales/es-ES/send.ftl:decryptingFile = Desencriptando...
public/locales/es-MX/send.ftl:importingFile = Importando...
public/locales/es-MX/send.ftl:verifyingFile = Verificando...
public/locales/es-MX/send.ftl:encryptingFile = Encriptando...
public/locales/es-MX/send.ftl:decryptingFile = Desencriptando...
public/locales/hsb/send.ftl:importingFile = Importuje so...
public/locales/hsb/send.ftl:verifyingFile = Přepruwuje so...
public/locales/hsb/send.ftl:encryptingFile = Zaklučuje so...
public/locales/hsb/send.ftl:decryptingFile = Dešifruje so...
public/locales/it/send.ftl:encryptingFile = Crittazione in corso...
public/locales/it/send.ftl:decryptingFile = Decrittazione in corso...
public/locales/ja/send.ftl:importingFile = インポート中...
public/locales/ja/send.ftl:verifyingFile = 検証中...
public/locales/ja/send.ftl:encryptingFile = 暗号化中...
public/locales/ja/send.ftl:decryptingFile = 復号化中...
public/locales/kab/send.ftl:importingFile = Akter...
public/locales/kab/send.ftl:verifyingFile = Asenqed...
public/locales/kab/send.ftl:encryptingFile = Awgelhen...
public/locales/kab/send.ftl:decryptingFile = Azmek...
public/locales/ms/send.ftl:verifyingFile = Mengesahkan...
public/locales/ms/send.ftl:encryptingFile = Mengenkripsi...
public/locales/ms/send.ftl:decryptingFile = Mengenkripsi...
public/locales/nb-NO/send.ftl:verifyingFile = Verifiserer...
public/locales/nb-NO/send.ftl:encryptingFile = Krypterer...
public/locales/nb-NO/send.ftl:decryptingFile = Dekrypterer...
public/locales/nn-NO/send.ftl:decryptingFile = Dekrypterer...
public/locales/pt-BR/send.ftl:encryptingFile = Criptografando...
There was a problem hiding this comment.
That's on locales to decide. It's definitely a rule for en-US.
Having said that, I fixed Italian because I was fooled by translation memory matches, and didn't realize it was 3 separate dots in Pontoon's interface.
There was a problem hiding this comment.
@flodo Yeah, I think the thing that caught my eye is that some locales were using both.
If we just look at public/locales/en-us/send.ftl, we should have four instances of … in the send.ftl file:
$ git grep "…" public/locales/en-US/send.ftl | wc -l # 4So any translations above that have all four instances using ... would be fine (dsb, es-ES, es-MX, hsb, ja, kab).
That leaves us with the following:
$ git grep -A 3 "importingFile = " public/locales/(cy|de|dsb|es-ES|es-MX|hsb|ja|kab|ms|nb-NO|nn-NO|pt-BR|pt-PT|ru|sk|sl)/send.ftl
public/locales/cy/send.ftl:importingFile = Mewnforio…
public/locales/cy/send.ftl-verifyingFile = Wrthi'n gwirio
public/locales/cy/send.ftl-encryptingFile = Wrthi'n amgryptio...
public/locales/cy/send.ftl-decryptingFile = Wrthi'n dadgryptio
--
public/locales/de/send.ftl:importingFile = Wird importiert…
public/locales/de/send.ftl-verifyingFile = Wird überprüft…
public/locales/de/send.ftl-encryptingFile = Wird verschlüsselt
public/locales/de/send.ftl-decryptingFile = Wird entschlüsselt...
--
public/locales/ms/send.ftl:importingFile = Mengimport…
public/locales/ms/send.ftl-verifyingFile = Mengesahkan...
public/locales/ms/send.ftl-encryptingFile = Mengenkripsi...
public/locales/ms/send.ftl-decryptingFile = Mengenkripsi...
--
public/locales/nb-NO/send.ftl:importingFile = Importerer…
public/locales/nb-NO/send.ftl-verifyingFile = Verifiserer...
public/locales/nb-NO/send.ftl-encryptingFile = Krypterer...
public/locales/nb-NO/send.ftl-decryptingFile = Dekrypterer...
--
public/locales/nn-NO/send.ftl:importingFile = Importerer…
public/locales/nn-NO/send.ftl-verifyingFile = Stadfestar…
public/locales/nn-NO/send.ftl-encryptingFile = Krypterer…
public/locales/nn-NO/send.ftl-decryptingFile = Dekrypterer...
--
public/locales/pt-BR/send.ftl:importingFile = Importando…
public/locales/pt-BR/send.ftl-verifyingFile = Verificando…
public/locales/pt-BR/send.ftl-encryptingFile = Criptografando...
public/locales/pt-BR/send.ftl-decryptingFile = Descriptografando...
--
public/locales/sk/send.ftl:importingFile = Importuje sa…
public/locales/sk/send.ftl-verifyingFile = Overuje sa…
public/locales/sk/send.ftl-encryptingFile = Šifruje sa...
public/locales/sk/send.ftl-decryptingFile = Dešifruje sa...
--
public/locales/sl/send.ftl:importingFile = Uvažanje …
public/locales/sl/send.ftl-verifyingFile = Preverjanje …
public/locales/sl/send.ftl-encryptingFile = Šifriranje ...
public/locales/sl/send.ftl-decryptingFile = Dešifriranje ...There was a problem hiding this comment.
Thanks for looking into this. Let me send an email to the mailing list and ask locales to look into it, it's a also a way to measure how much they follow communication (most of these locales should).
|
Thanks, I'll merge this one. Given how many locales had this issue, we need to find a solution for the UI (cc @mathjazz). Also CC @selimsumlu for Turkish. |
|
It's especially hard to distinguish when reviewing suggestions. I've fixed them for Turkish. |
I assume you're referring to …, and that's definitely true. Note that the ping was mostly about the missing attribute though. |
I totally missed those, and seems like I came across a Pontoon/FTL bug while playing with them. I'll file it on Bugzilla. |
|
I wonder if @mathjazz already fixed that. As far as I understand, the problem is (was) when a locale only submits one of the attributes. At that point, the file is exported on next sync and it's not possible anymore to add the second attribute, because it doesn't show up in the UI. |
|
Thanks for the ping. This issue is still in the wild and I'm working on it right now. It's being tracked here: |
Noticed this while playing w/
compare-locales l10n.toml . `ls public/locales` --data=json