-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good catch, Unfortunately it doesn't seem to be quite that simple.
The left
rule was added to support Firefox v51 and v52 (which you can download from http://ftp.mozilla.org/pub/firefox/releases/, if you'd like to test)
This is how it looks on 51 with the left rule removed:
arguably, it is more important to support mobile than older FF versions if we can't find a fix for this easily. |
@ericawright for me mobile first is important and also considering user who use different browser and screen size is good thing. |
I checked, and it will work for 51 and 52 if you add
Plus your removal of the left rule. While you're there, could you remove the Thanks for this! |
@ericawright thanks Erica, commit updated 5576bc0 |
(the test timing out is not your fault) Merging, thank you! |
Percentage number doesn't fit in the middle when using mobile browser, chrome, firefox and safari on desktop, this commit is simple solution.
Before
After
