This repository has been archived by the owner on May 22, 2021. It is now read-only.
filter the hash from error reports #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycoates
force-pushed
the
filter-sentry
branch
2 times, most recently
from
af2a473 to
5308a01
Compare
pdehaan
reviewed
Aug 2, 2017
views/jsconfig.handlebars
Outdated
| dataCallback: function (data) { | ||
| var hash = window.location.hash; | ||
| if (hash) { | ||
| return JSON.parse(JSON.stringify(data).replace(new Regexp(hash.slice(1), 'g'), '')); |
There was a problem hiding this comment.
Should be RegExp (per MDN)?
I was going to see if ESLint caught that, but I guess this is a weird hybrid .handlebars file, which linting would never see.
Not sure if we need to wrap any of that in a try..catch() in case something implodes unexpectedly.
There was a problem hiding this comment.
I think throwing is better in this case. It has the least surprising result, the report isn't sent. Returning null sends the original data including fragment, and returning {} also doesn't send the report but is less obvious what it might do.
dannycoates
force-pushed
the
filter-sentry
branch
from
5308a01 to
5944b85
Compare
pdehaan
reviewed
Aug 2, 2017
| @@ -92,6 +92,6 @@ | |||
| "test": "npm-run-all test:*", | |||
| "test:unit": "mocha test/unit", | |||
| "test:server": "mocha test/server", | |||
| "test:browser": "browserify test/frontend/frontend.bundle.js -o test/frontend/bundle.js -d && node test/frontend/driver.js" | |||
| "test--browser": "browserify test/frontend/frontend.bundle.js -o test/frontend/bundle.js -d && node test/frontend/driver.js" | |||
|
I generated a test error, and the fragment is no longer included https://sentry.prod.mozaws.net/operations/send-dev/issues/633106/ |
abhinadduri
approved these changes
Aug 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't want to know it