This repository has been archived by the owner on May 22, 2021. It is now read-only.
Cater for mobile and desktop #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should fall back to the ID, as far as I know, which means we should wait for at least major locales to catch up. One possible solution is to land the new string separately, then wait to merge this one (using the string) later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flodolo Does this look right?
Not sure how the other locales will handle the missing new ID, if they'll have an en_US fallback, or if the button label will say "uploadPageBrowseButton1" until the localizations come in.
Based on #456
Fixes #421