Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vf_d3d11vpp: adjust options for userdeint filter #14822

Merged
merged 1 commit into from
Sep 8, 2024
Merged

vf_d3d11vpp: adjust options for userdeint filter #14822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion filters/f_auto_filters.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ static void deint_process(struct mp_filter *f)
p->sub.filter =
mp_create_user_filter(f, MP_OUTPUT_CHAIN_VIDEO, "vdpaupp", args);
} else if (img->imgfmt == IMGFMT_D3D11) {
char *args[] = {"parity", field_parity, NULL};
char *args[] = {"deint", "yes",
"interlaced-only", "yes",
Copy link
Contributor

@hooke007 hooke007 Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not be correct here.
Manually enable deinterlace by user usually means the source was encoded to p.
Use interlaced-only=no

"parity", field_parity, NULL};
p->sub.filter =
mp_create_user_filter(f, MP_OUTPUT_CHAIN_VIDEO, "d3d11vpp", args);
} else if (img->imgfmt == IMGFMT_CUDA) {
Expand Down
3 changes: 3 additions & 0 deletions video/filter/vf_d3d11vpp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ static int recreate_video_proc(struct mp_filter *vf)
if (FAILED(hr))
goto fail;

if (!p->opts->mode && p->opts->deint_enabled)
p->opts->mode = D3D11_VIDEO_PROCESSOR_PROCESSOR_CAPS_DEINTERLACE_BOB;

int rindex = p->opts->mode ? -1 : 0;
if (rindex == 0)
goto create;
Expand Down