⬆️ 🛠️(deps): update dependency ruff to ^0.8.0 #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Reviewer's Guide by SourceryThis PR updates the Ruff linter dependency from version 0.6.0 to 0.8.0. The update includes breaking changes, new features, and bug fixes across multiple releases (0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, and 0.8.0). No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
![llamapreview[bot]](https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto Pull Request Review from LlamaPReview
1. Change Overview
1.1 Core Changes
- Primary purpose and scope: This pull request (PR) updates the dependency
rufffrom version^0.6.0to^0.8.0. - Key components modified: The
pyproject.tomlfile is modified to reflect the new version of theruffdependency. - Cross-component impacts: Updating the
ruffdependency may introduce new features, bug fixes, and breaking changes that could affect the overall system. - Business value alignment: The update aligns with maintaining up-to-date dependencies, ensuring compatibility, and leveraging new features and improvements.
1.2 Technical Architecture
- System design modifications: No significant changes to the system design.
- Component interaction changes: The update affects the linting and formatting rules applied by
ruff, which could impact code quality and adherence to coding standards. - Integration points impact: The integration points with
ruffmay require adjustments to accommodate new features and breaking changes. - Dependency changes and implications: The update introduces new rules, removes deprecated rules, and changes default behaviors, which need to be considered in the codebase.
2. Deep Technical Analysis
2.1 Code Logic Analysis
pyproject.toml
- Submitted PR Code:
--- +++ @@ -32,21 +32,21 @@ easyoanda = {version ="1.0.19", python = ">=3.11,<4.0"} ib_insync = "0.9.86" # mt5linux = "0.1.9" mt5linux_updated = "0.0.1" # pyetrade = {version ="2.1.0"} [tool.poetry.group.dev.dependencies] python-semantic-release = ">=8.0.8" -ruff = "^0.6.0" +ruff = "^0.8.0" pre-commit = "^4.0.0"
- Analysis:
- The version update for
ruffintroduces several breaking changes and new features that need to be carefully reviewed. - The update removes deprecated rules and adds new rules, which may affect the existing codebase.
- The version update for
- LlamaPReview Suggested Improvements:
# No specific code improvement needed for the version update itself. - Improvement rationale:
- Technical benefits: Ensuring compatibility with the latest version of
ruffand leveraging new features and improvements. - Business value: Maintaining up-to-date dependencies helps in improving code quality and adherence to coding standards.
- Risk assessment: The update introduces breaking changes that need to be carefully reviewed and tested to ensure they do not negatively impact the system.
- Technical benefits: Ensuring compatibility with the latest version of
2.2 Implementation Quality
-
Code Structure:
- Organization and modularity: The update is well-contained within the
pyproject.tomlfile. - Design pattern adherence: No changes to design patterns.
- Reusability aspects: The update does not affect the reusability of the code.
- Maintainability factors: Updating dependencies helps in maintaining the code and leveraging new features.
- Organization and modularity: The update is well-contained within the
-
Error Handling:
- Exception scenarios coverage: The update does not introduce new error handling scenarios.
- Recovery mechanisms: No changes to recovery mechanisms.
- Logging and monitoring: No changes to logging and monitoring.
- User experience impact: The update may affect the linting and formatting rules, which could impact the user experience during development.
-
Performance Considerations:
- Resource utilization: The update does not introduce significant changes to resource utilization.
- Scalability aspects: No changes to scalability.
- Bottleneck analysis: No new bottlenecks introduced.
- Optimization opportunities: The update leverages new features and improvements in
ruff, which may offer optimization opportunities.
3. Risk Assessment
3.1 Critical Issues
🔴 P0 (Must Fix):
- Issue:
- Breaking changes introduced in
ruffversion^0.8.0may affect the existing codebase.
- Breaking changes introduced in
- Impact:
- Technical implications: May result in linting and formatting issues in the codebase.
- Business consequences: May require additional development effort to address the breaking changes.
- User experience effects: May affect the user experience during development due to changes in linting and formatting rules.
- Resolution:
- Specific code changes: Review the breaking changes and update the codebase accordingly.
- Configuration updates: Update the
ruffconfiguration to accommodate new rules and changes. - Testing requirements: Conduct thorough testing to ensure the update does not introduce new issues.
3.2 Important Improvements
🟡 P1 (Should Fix):
- Issue:
- Ensure compatibility with the latest version of
ruff.
- Ensure compatibility with the latest version of
- Current Impact:
- Performance implications: No significant performance implications.
- Maintenance overhead: Updating dependencies helps in maintaining the code and leveraging new features.
- Future scalability: No changes to scalability.
- Suggested Solution:
- Implementation approach: Review the release notes and update the codebase to accommodate new features and breaking changes.
- Migration strategy: Plan a phased migration to address breaking changes and leverage new features.
- Testing considerations: Conduct thorough testing to ensure the update does not introduce new issues.
3.3 Minor Suggestions
🟢 P2 (Consider):
- Area: Documentation updates
- Improvement Opportunity:
- Code quality enhancement: Update the documentation to reflect the changes introduced in
ruffversion^0.8.0. - Best practice alignment: Ensure the documentation aligns with the latest coding standards and best practices.
- Documentation updates: Include detailed information on the breaking changes and new features introduced in the update.
- Code quality enhancement: Update the documentation to reflect the changes introduced in
4. Requirements Analysis
4.1 Functional Coverage
- Requirements mapping:
- Implemented features: The update introduces new features and improvements in
ruff. - Missing elements: No missing elements identified.
- Edge cases handling: Ensure that the breaking changes and new features are thoroughly tested for edge cases.
- Implemented features: The update introduces new features and improvements in
- Business Logic:
- Use case coverage: The update aligns with maintaining up-to-date dependencies and leveraging new features.
- Business rule implementation: No changes to business rules.
- Data flow correctness: No changes to data flow.
4.2 Non-functional Aspects
- Performance metrics: No significant changes to performance metrics.
- Security considerations: No new security considerations introduced.
- Scalability factors: No changes to scalability.
- Maintainability aspects: Updating dependencies helps in maintaining the code and leveraging new features.
5. Testing Strategy
- Test Coverage:
- Unit test requirements: Ensure unit tests cover the new features and changes introduced in
ruffversion^0.8.0. - Integration test scenarios: Conduct integration tests to ensure compatibility with the updated version of
ruff. - Edge case validation: Thoroughly test edge cases related to the breaking changes and new features.
- Unit test requirements: Ensure unit tests cover the new features and changes introduced in
- Quality Metrics:
- Current coverage: Ensure high test coverage for the updated codebase.
- Critical paths: Test critical paths to ensure the update does not introduce new issues.
- Performance benchmarks: No new performance benchmarks required.
6. Final Assessment
6.1 Key Action Items
-
Critical Changes (P0):
- Review the breaking changes introduced in
ruffversion^0.8.0and update the codebase accordingly. - Update the
ruffconfiguration to accommodate new rules and changes. - Conduct thorough testing to ensure the update does not introduce new issues.
- Review the breaking changes introduced in
-
Important Improvements (P1):
- Ensure compatibility with the latest version of
ruff. - Review the release notes and update the codebase to accommodate new features and breaking changes.
- Plan a phased migration to address breaking changes and leverage new features.
- Conduct thorough testing to ensure the update does not introduce new issues.
- Ensure compatibility with the latest version of
-
Suggested Enhancements (P2):
- Update the documentation to reflect the changes introduced in
ruffversion^0.8.0. - Ensure the documentation aligns with the latest coding standards and best practices.
- Include detailed information on the breaking changes and new features introduced in the update.
- Update the documentation to reflect the changes introduced in
6.2 Overall Evaluation
- Technical assessment: The update introduces new features and improvements, but also includes breaking changes that need to be carefully reviewed and tested.
- Business impact: Maintaining up-to-date dependencies helps in improving code quality and adherence to coding standards.
- Risk evaluation: The update introduces breaking changes that need to be carefully reviewed and tested to ensure they do not negatively impact the system.
- Implementation quality: The update is well-contained within the
pyproject.tomlfile and helps in maintaining the code and leveraging new features.
💡 LlamaPReview Community
Have feedback on this AI Code review tool? Join our GitHub Discussions to share your thoughts and help shape the future of LlamaPReview.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #548 +/- ##
==========================================
- Coverage 65.43% 64.56% -0.88%
==========================================
Files 10 10
Lines 570 570
==========================================
- Hits 373 368 -5
- Misses 197 202 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.6.0->^0.8.0Release Notes
astral-sh/ruff (ruff)
v0.8.0Compare Source
Check out the blog post for a migration guide and overview of the changes!
Breaking changes
See also, the "Remapped rules" section which may result in disabled rules.
Default to Python 3.9
Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Python version is configured using
ruff.target-versionorproject.requires-python(#13896)Changed location of
pydoclintdiagnosticspydoclintdiagnostics now point to the first-line of the problematic docstring. Previously, this was not the case.If you've opted into these preview rules but have them suppressed using
noqacomments insome places, this change may mean that you need to move the
noqasuppressioncomments. Most users should be unaffected by this change.
Use XDG (i.e.
~/.local/bin) instead of the Cargo home directory in the standalone installerPreviously, Ruff's installer used
$CARGO_HOMEor~/.cargo/binfor its target install directory. Now, Ruff will be installed into$XDG_BIN_HOME,$XDG_DATA_HOME/../bin, or~/.local/bin(in that order).This change is only relevant to users of the standalone Ruff installer (using the shell or PowerShell script). If you installed Ruff using uv or pip, you should be unaffected.
Changes to the line width calculation
Ruff now uses a new version of the unicode-width Rust crate to calculate the line width. In very rare cases, this may lead to lines containing Unicode characters being reformatted, or being considered too long when they were not before (
E501).Removed Rules
The following deprecated rules have been removed:
missing-type-self(ANN101)missing-type-cls(ANN102)syntax-error(E999)pytest-missing-fixture-name-underscore(PT004)pytest-incorrect-fixture-name-underscore(PT005)unpacked-list-comprehension(UP027)Remapped rules
The following rules have been remapped to new rule codes:
flake8-type-checking:TCHtoTCStabilization
The following rules have been stabilized and are no longer in preview:
builtin-import-shadowing(A004)mutable-contextvar-default(B039)fast-api-redundant-response-model(FAST001)fast-api-non-annotated-dependency(FAST002)dict-index-missing-items(PLC0206)pep484-style-positional-only-argument(PYI063)redundant-final-literal(PYI064)bad-version-info-order(PYI066)parenthesize-chained-operators(RUF021)unsorted-dunder-all(RUF022)unsorted-dunder-slots(RUF023)assert-with-print-message(RUF030)unnecessary-default-type-args(UP043)The following behaviors have been stabilized:
ambiguous-variable-name(E741): Violations in stub files are now ignored. Stub authors typically don't control variable names.printf-string-formatting(UP031): Report allprintf-like usages even if no autofix is availableThe following fixes have been stabilized:
zip-instead-of-pairwise(RUF007)Preview features
flake8-datetimez] Exemptmin.time()andmax.time()(DTZ901) (#14394)flake8-pie] Mark fix as unsafe if the following statement is a string literal (PIE790) (#14393)flake8-pyi] New ruleredundant-none-literal(PYI061) (#14316)flake8-pyi] Add autofix forredundant-numeric-union(PYI041) (#14273)ruff] New rulemap-int-version-parsing(RUF048) (#14373)ruff] New ruleredundant-bool-literal(RUF038) (#14319)ruff] New ruleunraw-re-pattern(RUF039) (#14446)pycodestyle] Exemptpytest.importorskip()calls (E402) (#14474)pylint] Autofix suggests using sets when possible (PLR1714) (#14372)Rule changes
invalid-pyproject-toml(RUF200): Updated to reflect the provisionally accepted PEP 639.flake8-pyi] Avoid panic in unfixable case (PYI041) (#14402)flake8-type-checking] Correctly handle quotes in subscript expression when generating an autofix (#14371)pylint] Suggest correct autofix for__contains__(PLC2801) (#14424)Configuration
ignores a rule that has been removed (#14435)lint.flake8-import-conventions.aliasesonly uses valid module names and aliases (#14477)v0.7.4Compare Source
Preview features
flake8-datetimez] Detect usages ofdatetime.max/datetime.min(DTZ901) (#14288)flake8-logging] Implementroot-logger-calls(LOG015) (#14302)flake8-no-pep420] Detect empty implicit namespace packages (INP001) (#14236)flake8-pyi] Add "replace withSelf" fix (PYI019) (#14238)perflint] Implement quick-fix formanual-list-comprehension(PERF401) (#13919)pylint] Implementshallow-copy-environ(W1507) (#14241)ruff] Implementnone-not-at-end-of-union(RUF036) (#14314)ruff] Implementationunsafe-markup-callfromflake8-markupsafeplugin (RUF035) (#14224)ruff] Report problems forattrsdataclasses (RUF008,RUF009) (#14327)Rule changes
flake8-boolean-trap] Exclude dunder methods that define operators (FBT001) (#14203)flake8-pyi] Add "replace withSelf" fix (PYI034) (#14217)flake8-pyi] Always autofixduplicate-union-members(PYI016) (#14270)flake8-pyi] Improve autofix for nested and mixed type unions forunnecessary-type-union(PYI055) (#14272)flake8-pyi] Mark fix as unsafe when type annotation contains comments forduplicate-literal-member(PYI062) (#14268)Server
ruff.configuration(#14352)Bug fixes
PLC014(useless-import-alias) andI002(missing-required-import) by consideringlint.isort.required-importsforPLC014(#14287)flake8-type-checking] Skip quoting annotation if it becomes invalid syntax (TCH001)flake8-pyi] Avoid usingtyping.Selfin stub files pre-Python 3.11 (PYI034) (#14230)flake8-pytest-style] Flagpytest.raisescall with keyword argumentexpected_exception(PT011) (#14298)flake8-simplify] Infer "unknown" truthiness for literal iterables whose items are all unpacks (SIM222) (#14263)flake8-type-checking] Fix false positives fortyping.Annotated(TCH001) (#14311)pylint] Allowawaitat the top-level scope of a notebook (PLE1142) (#14225)pylint] Fix miscellaneous issues inawait-outside-asyncdetection (PLE1142) (#14218)pyupgrade] Avoid applying PEP 646 rewrites in invalid contexts (UP044) (#14234)pyupgrade] Detect permutations in redundant open modes (UP015) (#14255)refurb] Avoid triggeringhardcoded-string-charsetfor reordered sets (FURB156) (#14233)refurb] Further special cases added toverbose-decimal-constructor(FURB157) (#14216)refurb] UseUserStringinstead of non-existentUserStr(FURB189) (#14209)ruff] Avoid treating lowercase letters as# noqacodes (RUF100) (#14229)ruff] Do not report whenOptionalhas no type arguments (RUF013) (#14181)Documentation
F704,PLE1142(#14266)v0.7.3Compare Source
Preview features
flake8-pyi] Include all Python file types forPYI006andPYI066(#14059)flake8-simplify] Implementsplit-of-static-string(SIM905) (#14008)refurb] Implementsubclass-builtin(FURB189) (#14105)ruff] Improve diagnostic messages and docs (RUF031,RUF032,RUF034) (#14068)Rule changes
B033,PLC0208) (#14064)eradicate] Better detection of IntelliJ language injection comments (ERA001) (#14094)flake8-pyi] Add autofix fordocstring-in-stub(PYI021) (#14150)flake8-pyi] Updateduplicate-literal-member(PYI062) to alawys provide an autofix (#14188)pyflakes] Detect items that hash to same value in duplicate dictionaries (F601) (#14065)ruff] Fix false positive for decorators (RUF028) (#14061)Bug fixes
# noqa(#12809)eradicate] ignore# language=in commented-out-code rule (ERA001) (#14069)flake8-bugbear] - do not runmutable-argument-defaulton stubs (B006) (#14058)flake8-builtins] Skip lambda expressions inbuiltin-argument-shadowing (A002)(#14144)flake8-comprehension] Also remove trailing comma while fixingC409andC419(#14097)flake8-simplify] Allowopenwithout context manager inreturnstatement (SIM115) (#14066)pylint] Respect hash-equivalent literals initeration-over-set(PLC0208) (#14063)pylint] Update known dunder methods for Python 3.13 (PLW3201) (#14146)pyupgrade] - ignore kwarg unpacking forUP044(#14053)refurb] Parse more exotic decimal strings inverbose-decimal-constructor(FURB157) (#14098)Documentation
v0.7.2Compare Source
Preview features
pyupgrade] Add PEP 646Unpackconversion to*with fix (UP044) (#13988)Rule changes
known_stdlibs.rswith stdlibs 2024.10.25 (#13963)flake8-no-pep420] Skip namespace package enforcement for PEP 723 scripts (INP001) (#13974)Server
Bug fixes
flake8-type-checking] Fix false positive forsingledispatchmethod(TCH003) (#13941)flake8-type-checking] Treat return type ofsingledispatchas runtime-required (TCH003) (#13957)Documentation
flake8-simplify] Include caveats of enablingif-else-block-instead-of-if-exp(SIM108) (#14019)v0.7.1Compare Source
Preview features
E221andE222to flag missing or extra whitespace around==operator (#13890)pylint] Restrictiteration-over-setto only work on sets of literals (PLC0208) (#13731)Rule changes
flake8-type-checking] Support auto-quoting when annotations contain quotes (#11811)Server
Bug fixes
ARG002compatible withEM101when raisingNotImplementedError(#13714)Other changes
v0.7.0Compare Source
Check out the blog post for a migration guide and overview of the changes!
Breaking changes
PT001andPT023now default to omitting the decorator parentheses when there are no arguments(#12838, #13292).
This was a change that we attempted to make in Ruff v0.6.0, but only partially made due to an error on our part.
See the blog post for more details.
useless-try-exceptrule (in ourtryceratopscategory) has been recoded fromTRY302toTRY203(#13502). This ensures Ruff's code is consistent withthe same rule in the
tryceratopslinter.lint.allow-unused-importssetting has been removed (#13677). Uselint.pyflakes.allow-unused-importsinstead.
Formatter preview style
Preview linter features
refurb] implementhardcoded-string-charset(FURB156) (#13530)refurb] Count codepoints not bytes forslice-to-remove-prefix-or-suffix (FURB188)(#13631)Rule changes
pylint] MarkPLE1141fix as unsafe (#13629)flake8-async] Consider async generators to be "checkpoints" forcancel-scope-no-checkpoint(ASYNC100) (#13639)flake8-bugbear] Do not suggest setting parameterstrict=toFalseinB905diagnostic message (#13656)flake8-todos] Only flag the word "TODO", not words starting with "todo" (TD006) (#13640)pycodestyle] Fix whitespace-related false positives and false negatives inside type-parameter lists (E231,E251) (#13704)flake8-simplify] Stabilize preview behavior forSIM115so that the rule can detect filesbeing opened from a wider range of standard-library functions (#12959).
CLI
--statisticscommand (#13774)Bug fixes
pyflakes] Allowipytestcell magic (F401) (#13745)flake8-use-pathlib] FixPTH123false positive whenopenis passed a file descriptor (#13616)flake8-bandit] Detect patterns from multi line SQL statements (S608) (#13574)flake8-pyi] - Fix dropped expressions inPYI030autofix (#13727)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by Sourcery
Build: