Me 1 - 0 Glibc: replace buggy Glibc condvar by futex #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like distinct Atomic[int32] lead to bad codegen on C++: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Lock+Condition variables by futex on Linux.
It solves the nasty #56 bug which is due to a Glibc and Musl bug on condvar signaling not waking up all thread.
Would be nice to use futex on Windows as well as they are supported there and are much more lightweight than condition variables + lock (4 bytes vs ~72 bytes on Linux) plus we don't need all the extra fluff that mutexes and condition variables have to guard against as we have formally verified that just wait+wake is enough.