Added explicit any type to generic promise

[awwong1]

promise error from ts #1

[mrbar42]

Thanks for this!

@awwong1 can you share a code example that reproduces that error so i can add it to the TypeScript tests?

[awwong1]

Sure! I am using this library in a typescript express web app.

This is my typescript configuration:

{
  "compilerOptions": {
    "target": "es2015",
    "module": "commonjs",
    "sourceMap": true,
    "outDir": "dist",
    "strict": true,
    "strictPropertyInitialization": false,
    "esModuleInterop": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true
  },
  "include": [
    "src/**/*.ts"
  ],
  "exclude": [
    "node_modules"
  ]
}

Here's my index.ts file:

import { createServer } from "http";
import Graceful from "node-graceful";
import { createConnection } from "typeorm";
import app from "./app";
import { NODE_ENV, PORT } from "./constants";
import logger from "./util/logger";

/**
 * Start the server. Initialize the Database Client and tables.
 */
const start = async () => {
  const connection = await createConnection();
  logger.info(
    `Connected to ${connection.options.database} ${connection.options.type}: ${
      connection.isConnected
    }`
  );
  app.set("dbConnection", connection);
  const server = createServer(app);

  server.listen(PORT, async () => {
    logger.info(`UDIA ${NODE_ENV} server running on port ${PORT}`);
  });

  Graceful.on("exit", (done, event, signal) => {
    logger.warn(`3)\tSignal ${signal} received.`);
    server.close(() => {
      logger.warn(`2)\tHTTP server closed.`);
      connection.close().then(() => {
        logger.warn(`1)\tDatabase connections closed.`);
        done();
      });
    });
  });
  return server;
};

if (require.main === module) {
  start();
}

export default start;

Running tsc shows the following warning in console output:

➜  udia git:(master) ✗ tsc
node_modules/node-graceful/index.d.ts(1,86): error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

[awwong1]

Also, in VSCode with the typescript extensions, I see this error: