Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify all package related names to msgpack-c. #1053

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Unify all package related names to msgpack-c. #1053

merged 1 commit into from
Mar 4, 2023

Conversation

redboltz
Copy link
Contributor

Update the version to 6.0.0.

@redboltz redboltz force-pushed the unify_project_name_c branch from c467249 to 01f3d24 Compare February 28, 2023 01:49
@redboltz redboltz mentioned this pull request Feb 28, 2023
Closed
@redboltz redboltz merged commit b3de6f8 into msgpack:c_master Mar 4, 2023
@redboltz redboltz deleted the unify_project_name_c branch March 4, 2023 12:35
@chenrui333 chenrui333 mentioned this pull request Mar 5, 2023
Closed
@carlocab
Copy link

carlocab commented Mar 5, 2023 •
edited
Loading

Renaming libmsgpackc to libmsgpack-c will break all software that links with libmsgpackc, because they don't know to look for libmsgpack-c instead.

Given that the SOVERSION has not changed, perhaps it would be good to provide symlinks from libmsgpack-c to libmsgpackc to avoid having to recompile dependent software (and patch their build systems in the meantime so they know they have to look for msgpack-c instead of just msgpack)?

This was referenced Mar 5, 2023
Closed
Closed
carlocab added a commit to carlocab/tmate that referenced this pull request Mar 5, 2023
@carlocab
Fix finding msgpack 6+
a5c6e80 
`msgpack.pc` was renamed to `msgpack-c.pc` upstream in msgpack/msgpack-c#1053.
This was referenced Mar 5, 2023
Open
Merged
@redboltz
Copy link
Contributor Author

redboltz commented Mar 6, 2023 •
edited
Loading

@carlocab

Thank you for the comment. The current SOVERSION is 2.0.0. I didn't update the SOVERSION because no function interface has been changed. But I noticed that library name is a part of public intercace. So SOVERSION should be updated to 3.0.0.

I will create the PR that updates SOVERSION from 2.0.0 to 3.0.0 and the msgpack-c version from 6.0.0 to 6.0.1.
The reason updated to 6.0.1 is fixing the bug that is missing SOVERSION update.

What do you think?

@carlocab
Copy link

carlocab commented Mar 7, 2023

I think staying with the SOVERSION of 2.0.0 is fine. msgpack-c 6.0.0 is binary compatible with msgpack-c 5.0.0, so there is no need to force rebuilding of clients here.

@memsharded memsharded mentioned this pull request Mar 14, 2023
Merged
3 tasks
equalsraf pushed a commit to equalsraf/neovim-qt that referenced this pull request Mar 16, 2023
@carlocab @equalsraf
Fix finding msgpack 6+
c6ae970 
`libmsgpackc` was renamed to `libmsgpack-c` in 6.0.0. See
msgpack/msgpack-c#1053.
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Apr 3, 2023
@thesamesam
dev-libs/msgpack: add upstream ref re library rename
cea1c46 
Followup to 49c8b9c.

Bug: msgpack/msgpack-c#1053
Signed-off-by: Sam James <[email protected]>
@dundargoc dundargoc mentioned this pull request Oct 17, 2023
Merged
@redboltz redboltz added the C label Apr 2, 2024
kravciak pushed a commit to kravciak/tmate that referenced this pull request Aug 29, 2024
@carlocab @kravciak
Fix finding msgpack 6+
36f2464 
`msgpack.pc` was renamed to `msgpack-c.pc` upstream in msgpack/msgpack-c#1053.
@zw963 zw963 mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees
No one assigned
Labels
C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redboltz @carlocab @traversaro