Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3258 Dev Deps Upgrades #3264

Merged
merged 15 commits into from
Dec 4, 2020
Merged

#3258 Dev Deps Upgrades #3264

merged 15 commits into from
Dec 4, 2020

Conversation

josh-griffin
Copy link
Contributor

Fixes #3258 - kind of, need a part 2 (maybe 3)

Change summary

Prettier 2.2.1 https://github.com/prettier/prettier/releases

  • Breaking changes 2.0
  • Made arrow-parens default 'always'. It makes sense but is a lot of work to go through every file and update them so instead disabled within the config

lint-staged & Husky: 5.0.0:

eslint-plugin-react

  • Nothing

eslint-plugin-prettier

  • Nothing

eslint-plugin-import

  • Nothing

eslint

victory-native

  • Nothing

reselect

  • Nothing

currency.js

ajv

  • Nothing
  • New major in Beta

moment

  • Nothing

Realm 3.1.5 -> 10 [They skipped v4,7,8,9].

  • Was a bug in realm that after upgrading babel meant it wouldn't work, so upgraded in this PR.
  • Fixed: Rare crash (EXC_BAD_ACCESS KERN_INVALID_ADDRESS in realm::Table::migrate_links) when a schema was updated - Think I saw this a few times
  • Collection/Objects: toJSON() method
  • A lot of changes to sync and interaction wiht mongoDB, mainly
  • Required to bump the node version

Testing

  • App work good?

Related areas to think about

n/A

@josh-griffin josh-griffin changed the base branch from master to develop November 28, 2020 22:08
12.20.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped - up to node 15 now 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 .

wlthomson
wlthomson previously approved these changes Nov 30, 2020
Copy link
Contributor

@wlthomson wlthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

12.20.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 .

@mark-prins
Copy link
Contributor

I took the branch, installed and started - and it crashes on my emulator. Perhaps after the branch merging it will all come together? This is the error showing:

2020-12-02 17:28:11.556 5700-5745/com.msupplymobile E/SoLoader: couldn't find DSO to load: libreactnativejni.so
2020-12-02 17:28:11.558 5700-5745/com.msupplymobile E/AndroidRuntime: FATAL EXCEPTION: OkHttp Dispatcher
    Process: com.msupplymobile, PID: 5700
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libreactnativejni.so
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:738)

@josh-griffin
Copy link
Contributor Author

@mark-prins

Thanks a lot for checking it out. Maybe I should merge all the deps upgrade PRs into one? I was trying to make it easier to review, but that might be a fail.

I would like to make sure people can still build before I go breaking develop - are you able to cd android && ./gradlew clean as well as yarn clean-mac-cache ? It's also possible the java version might make a difference and I might need to bump the sdkman version

@josh-griffin
Copy link
Contributor Author

What I tested with:
image

after clearing caches using yarn clean-mac-cache and cd android && ./gradlew clean, yarn start works. Also deleted the repository and recloned and was OK. The gradlew clean step seems important - I think it is clearing the build of react-native in the cache which might account for the missing .so. But not 100% :)

@mark-prins
Copy link
Contributor

I clean forgot about cleaning up! thanks @joshxg

@josh-griffin josh-griffin merged commit 188a9f1 into develop Dec 4, 2020
@josh-griffin josh-griffin deleted the #3258-deps-upgrade branch December 4, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies upgrade
3 participants