Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync pathconv tests #58

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Sync pathconv tests #58

merged 3 commits into from
Jan 6, 2024

Conversation

lazka
Copy link
Member

@lazka lazka commented Dec 22, 2023

dscho
dscho reviewed Dec 23, 2023
View reviewed changes
Copy link
Contributor

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting in this work! I would approve them, but I believe that we'll have to revisit a couple of the backported pathconv changes, based on some of the changes in behavior pointed out by this PR.

@lazka
Copy link
Member Author

lazka commented Jan 6, 2024

Thanks for the review!

@lazka lazka merged commit 5180ba5 into msys2:main Jan 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazka @dscho