Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when using Rule classes #15

Closed
wants to merge 8 commits into from

Conversation

ivan770
Copy link

@ivan770 ivan770 commented Dec 5, 2019

Fix ErrorException : substr() expects parameter 1 to be string, object given when using object classes in Form Requests

@mtrajano
Copy link
Owner

mtrajano commented Dec 5, 2019

Hello thank you for the for the pr, I will take a look at it tonight. In the meantime would you mind adding a test to validate the fix? Thanks once again!

@mtrajano
Copy link
Owner

mtrajano commented Dec 5, 2019

Also wondering if this is breaking for closure validation as well, we may just want to check that the rule is a string. Please see #14

@mtrajano
Copy link
Owner

mtrajano commented Dec 6, 2019

This has been fixed with #14 and should be working as of v0.6.1. I like what you're doing with responses and think it can become a potential feature as some people have been asking for this, although it would probably require some small discussion. But please don't change anything with the authors or the package namespace. If you would like to become a maintainer we can talk about it.

@mtrajano mtrajano closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants