-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize paths #365
Normalize paths #365
Conversation
Test failures look unrelated (a Codecov API rate limiting issue). |
I agree the coverage jobs are probably a ci configuration issue and can be ignored. But the windows jobs are failing too. |
This is not compatible with tox 4 and has a different meaning there. Signed-off-by: Stephen Finucane <[email protected]>
Good point. Fixed those. I also pinched part of Takashi-san's tox 4 compat change (#360) so I could actually test this locally (though not actually on Windows sadly). We might want to merge that entire PR at some point. EDIT: Nope, still not working.
So where is EDIT: Okay, actually fixed now. Another test was failing 🤦 |
Different testenv's can't share an envdir in tox 4. In addition, there's no reason to set the VIRTUALENV envvar. Stop doing both. Signed-off-by: Stephen Finucane <[email protected]>
Windows users are likely to pass Windows-style paths. Handle this correctly. This highlight a lot of naive use of *nix style paths in tests, but cleaning those up is a job for another day/PR. Signed-off-by: Stephen Finucane <[email protected]>
Fixes mtreinish#364. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 61.65% 61.48% -0.18%
==========================================
Files 30 30
Lines 2608 2617 +9
Branches 402 404 +2
==========================================
+ Hits 1608 1609 +1
- Misses 881 889 +8
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Fixes #364.