Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths #365

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Normalize paths #365

merged 6 commits into from
Nov 23, 2024

Conversation

stephenfin
Copy link
Contributor

Fixes #364.

@stephenfin
Copy link
Contributor Author

Test failures look unrelated (a Codecov API rate limiting issue).

@mtreinish
Copy link
Owner

I agree the coverage jobs are probably a ci configuration issue and can be ignored. But the windows jobs are failing too.
It looks like there is an issue on windows that ci is catching here: https://github.com/mtreinish/stestr/actions/runs/10595299313/job/29361543634?pr=365#step:6:7049

This is not compatible with tox 4 and has a different meaning there.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
Copy link
Contributor Author

stephenfin commented Aug 29, 2024

Good point. Fixed those. I also pinched part of Takashi-san's tox 4 compat change (#360) so I could actually test this locally (though not actually on Windows sadly). We might want to merge that entire PR at some point.

EDIT: Nope, still not working. os.path.normpath says:

On Windows, it converts forward slashes to backward slashes

So where is tests/test_passing coming from? 😕

EDIT: Okay, actually fixed now. Another test was failing 🤦

Different testenv's can't share an envdir in tox 4. In addition, there's
no reason to set the VIRTUALENV envvar. Stop doing both.

Signed-off-by: Stephen Finucane <[email protected]>
Windows users are likely to pass Windows-style paths. Handle this
correctly.

This highlight a lot of naive use of *nix style paths in tests, but
cleaning those up is a job for another day/PR.

Signed-off-by: Stephen Finucane <[email protected]>
Fixes mtreinish#364.

Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 61.48%. Comparing base (1dd16b3) to head (8659f2a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
stestr/commands/run.py 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   61.65%   61.48%   -0.18%     
==========================================
  Files          30       30              
  Lines        2608     2617       +9     
  Branches      402      404       +2     
==========================================
+ Hits         1608     1609       +1     
- Misses        881      889       +8     
  Partials      119      119              
Flag Coverage Δ
unittests 61.48% <5.88%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mtreinish mtreinish merged commit 7951fa1 into mtreinish:main Nov 23, 2024
20 checks passed
@stephenfin stephenfin deleted the issue-364 branch November 24, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths provided by -n are not normalized
2 participants